Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(69241)

#20223: inspect.signature does not support new functools.partialmethod

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by yselivanov
Modified:
5 years, 5 months ago
Reviewers:
ncoghlan
CC:
brett.cannon, terry.reedy, Nick Coghlan, larry, devnull_psf.upfronthosting.co.za, Yury Selivanov
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/functools.py View 1 chunk +1 line, -0 lines 1 comment Download
Lib/inspect.py View 3 chunks +66 lines, -40 lines 0 comments Download
Lib/test/test_inspect.py View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Nick Coghlan
5 years, 5 months ago #1
Aside from the suggestion of using a normal private attribute (_partialmethod)
rather than an interpreter reserved name, Yury's patch looks good to me.

http://bugs.python.org/review/20223/diff/10529/Lib/functools.py
File Lib/functools.py (right):

http://bugs.python.org/review/20223/diff/10529/Lib/functools.py#newcode293
Lib/functools.py:293: _method.__partialmethod__ = self
I suggest using an ordinary private attribute (_partialmethod) for the moment.
For 3.5, it would be good to review the various introspection changes we've made
for 3.4, and see which can be cleaned up and unified into a consistent improved
introspection protocol.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+