Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(119920)

#20218: Add `pathlib.Path.write` and `pathlib.Path.read`

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by ram
Modified:
5 years, 1 month ago
Reviewers:
pitrou, georg
CC:
Georg, AntoinePitrou, matthiastroffaes, cool-RR, devnull_psf.upfronthosting.co.za, cjwelborn
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Patch Set 8 #

Total comments: 6

Patch Set 9 #

Total comments: 1

Patch Set 10 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/pathlib.rst View 1 2 3 4 5 6 7 8 9 2 chunks +61 lines, -0 lines 0 comments Download
Lib/pathlib.py View 1 2 3 4 5 6 7 8 9 1 chunk +33 lines, -0 lines 0 comments Download
Lib/test/test_pathlib.py View 1 2 3 4 5 6 7 8 9 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4
AntoinePitrou
Thanks! Here are finally some comments. http://bugs.python.org/review/20218/diff/10866/Lib/pathlib.py File Lib/pathlib.py (right): http://bugs.python.org/review/20218/diff/10866/Lib/pathlib.py#newcode1087 Lib/pathlib.py:1087: def write_bytes(self, data, ...
5 years, 8 months ago #1
AntoinePitrou
http://bugs.python.org/review/20218/diff/12958/Lib/test/test_pathlib.py File Lib/test/test_pathlib.py (right): http://bugs.python.org/review/20218/diff/12958/Lib/test/test_pathlib.py#newcode1317 Lib/test/test_pathlib.py:1317: self.assertRaises(TypeError, (p / 'fileA').write_bytes, 'somestr') What is the content ...
5 years, 1 month ago #2
Georg
On 2014/09/30 16:34:12, AntoinePitrou wrote: > http://bugs.python.org/review/20218/diff/12958/Lib/test/test_pathlib.py > File Lib/test/test_pathlib.py (right): > > http://bugs.python.org/review/20218/diff/12958/Lib/test/test_pathlib.py#newcode1317 > ...
5 years, 1 month ago #3
AntoinePitrou
5 years, 1 month ago #4
This looks good to me, thanks!
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+