Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

#20197: Support WebP image format detection in imghdr module

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by akh
Modified:
6 years ago
Reviewers:
xavier.combelle, georg
CC:
gregory.p.smith, Claudiu.Popa, devnull_psf.upfronthosting.co.za, berkerpeksag, storchaka, xcombelle, akh_nobugware.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 1

Patch Set 3 #

Total comments: 3

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/imghdr.rst View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
Lib/imghdr.py View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
Lib/test/test_imghdr.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
xcombelle
6 years ago #1
xcombelle
shouldn't ('python.webp', 'webp') be ('python.webp', 'webp'), for future improved patch
6 years ago #2
xcombelle
http://bugs.python.org/review/20197/diff/11248/Lib/test/test_imghdr.py File Lib/test/test_imghdr.py (right): http://bugs.python.org/review/20197/diff/11248/Lib/test/test_imghdr.py#newcode20 Lib/test/test_imghdr.py:20: ('python.webp', 'webp') should be ('python.webp', 'webp'), for cleaner future ...
6 years ago #3
Georg
http://bugs.python.org/review/20197/diff/11250/Doc/library/imghdr.rst File Doc/library/imghdr.rst (right): http://bugs.python.org/review/20197/diff/11250/Doc/library/imghdr.rst#newcode52 Doc/library/imghdr.rst:52: +------------+-----------------------------------+ needs a "versionchanged" tag to inform that webp ...
6 years ago #4
Georg
6 years ago #5
http://bugs.python.org/review/20197/diff/11250/Lib/test/test_imghdr.py
File Lib/test/test_imghdr.py (right):

http://bugs.python.org/review/20197/diff/11250/Lib/test/test_imghdr.py#newcode20
Lib/test/test_imghdr.py:20: ('python.webp', 'webp'),
On 2014/03/10 22:08:03, Georg wrote:
> Where is this file? it has to be produced and checked in as well (into
> Lib/test/imghdrdata).

Hmm, I see the file is in the original patch on bugs.python.org -- apparently
Rietveld cannot handle it.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+