Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22126)

#20181: Derby #12: Convert 50 sites to Argument Clinic across 4 files

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by larry
Modified:
4 years, 5 months ago
Reviewers:
storchaka
CC:
larry, devnull_psf.upfronthosting.co.za, storchaka, ZackerySpytz
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Modules/unicodedata.c View 10 chunks +556 lines, -231 lines 3 comments Download

Messages

Total messages: 2
larry
Looks great! You have to redo some type mapping because of my change to Clinic, ...
4 years, 5 months ago #1
storchaka_gmail.com
4 years, 5 months ago #2
Thank you for your review Larry!

http://bugs.python.org/review/20181/diff/14304/Modules/unicodedata.c
File Modules/unicodedata.c (right):

http://bugs.python.org/review/20181/diff/14304/Modules/unicodedata.c#newcode1624
Modules/unicodedata.c:1624: if (!_getcode(self, name, (int)name_length, &code,
1)) {
On 2015/04/16 22:57:41, larry wrote:
> Should Clinic allow length='namelen' for renaming the variable?

I think that converters with length=True should gone in future. Functions accept
either unicode object, or null-terminated C string (null in the middle is not
allowed), or byte-like object, or read-only byte-like object and str encoded
with "ascii" or "utf-8". In the last case I think the argument should be
converted to Py_buffer. "s#" and others are legacy.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+