Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48739)

#20180: Derby #11: Convert 50 sites to Argument Clinic across 9 files

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by larry
Modified:
2 years, 9 months ago
Reviewers:
martin, taleinat, storchaka, vadmium+py, songofacandy
CC:
loewis, rhettinger, taleinat, larry, rbcollins, inada.naoki, skrah, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 6

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Total comments: 2

Patch Set 8 #

Patch Set 9 #

Patch Set 10 #

Total comments: 19

Patch Set 11 #

Patch Set 12 #

Patch Set 13 #

Total comments: 22

Patch Set 14 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Objects/clinic/unicodeobject.c.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +894 lines, -1 line 0 comments Download
Objects/unicodeobject.c View 1 2 3 4 5 6 7 8 9 10 11 12 13 33 chunks +584 lines, -481 lines 0 comments Download

Messages

Total messages: 12
loewis
http://bugs.python.org/review/20180/diff/10695/Lib/random.py File Lib/random.py (right): http://bugs.python.org/review/20180/diff/10695/Lib/random.py#newcode85 Lib/random.py:85: return super().__new__(cls, 0) What is this for? ISTM that ...
5 years, 2 months ago #1
loewis
http://bugs.python.org/review/20180/diff/10676/Objects/unicodeobject.c File Objects/unicodeobject.c (right): http://bugs.python.org/review/20180/diff/10676/Objects/unicodeobject.c#newcode11968 Objects/unicodeobject.c:11968: eturn True if the string is a decimal string; ...
5 years, 2 months ago #2
loewis
http://bugs.python.org/review/20180/diff/10628/Modules/_collectionsmodule.c File Modules/_collectionsmodule.c (right): http://bugs.python.org/review/20180/diff/10628/Modules/_collectionsmodule.c#newcode13 Modules/_collectionsmodule.c:13: class collections.Counter _count_elements is a module-level function, not a ...
5 years, 2 months ago #3
taleinat
On 2014/07/27 17:38:59, loewis wrote: > http://bugs.python.org/review/20180/diff/10628/Modules/_collectionsmodule.c > File Modules/_collectionsmodule.c (right): > > http://bugs.python.org/review/20180/diff/10628/Modules/_collectionsmodule.c#newcode13 > ...
5 years, 2 months ago #4
taleinat
http://bugs.python.org/review/20180/diff/10695/Lib/random.py File Lib/random.py (right): http://bugs.python.org/review/20180/diff/10695/Lib/random.py#newcode85 Lib/random.py:85: return super().__new__(cls, 0) On 2014/07/27 17:00:19, loewis wrote: > ...
5 years, 2 months ago #5
taleinat
http://bugs.python.org/review/20180/diff/10676/Objects/unicodeobject.c File Objects/unicodeobject.c (right): http://bugs.python.org/review/20180/diff/10676/Objects/unicodeobject.c#newcode11968 Objects/unicodeobject.c:11968: eturn True if the string is a decimal string; ...
4 years, 5 months ago #6
storchaka_gmail.com
http://bugs.python.org/review/20180/diff/14701/Objects/unicodeobject.c File Objects/unicodeobject.c (right): http://bugs.python.org/review/20180/diff/14701/Objects/unicodeobject.c#newcode58 Objects/unicodeobject.c:58: converter = 'convert_uc' Add def converter_init(self): if self.default is ...
4 years, 5 months ago #7
taleinat
http://bugs.python.org/review/20180/diff/14701/Objects/unicodeobject.c File Objects/unicodeobject.c (right): http://bugs.python.org/review/20180/diff/14701/Objects/unicodeobject.c#newcode58 Objects/unicodeobject.c:58: converter = 'convert_uc' On 2015/04/23 08:39:25, storchaka wrote: > ...
4 years, 5 months ago #8
storchaka_gmail.com
http://bugs.python.org/review/20180/diff/14701/Objects/unicodeobject.c File Objects/unicodeobject.c (right): http://bugs.python.org/review/20180/diff/14701/Objects/unicodeobject.c#newcode58 Objects/unicodeobject.c:58: converter = 'convert_uc' On 2015/04/23 18:03:08, taleinat wrote: > ...
4 years, 5 months ago #9
taleinat
http://bugs.python.org/review/20180/diff/14701/Objects/unicodeobject.c File Objects/unicodeobject.c (right): http://bugs.python.org/review/20180/diff/14701/Objects/unicodeobject.c#newcode58 Objects/unicodeobject.c:58: converter = 'convert_uc' On 2015/04/23 21:47:30, storchaka wrote: > ...
4 years, 5 months ago #10
Martin Panter
https://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c File Objects/unicodeobject.c (right): https://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c#newcode10732 Objects/unicodeobject.c:10732: Return a version of the string where each word ...
2 years, 9 months ago #11
inada.naoki
2 years, 9 months ago #12
Thanks!

http://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c
File Objects/unicodeobject.c (right):

http://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c#newcod...
Objects/unicodeobject.c:10732: Return a version of the string where each word is
capitalized.
On 2017/01/16 01:10:48, vadmium wrote:
> This changed the terminology. To me, “capitalize” is more likely to suggest
all
> uppercase, not just the initial character, and the capitalize() method name is
> unfortunate.

fixed

> Also, it is good to mention “title case”, because Unicode has title-case code
> points that are neither purely upper- nor lower-case. E.g. U+01F2 Dz (Latin
> capital letter D with small letter Z).

I didn't, because I'm not unicode expert and I want to focus to commit ACed
code.

http://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c#newcod...
Objects/unicodeobject.c:10734: More specifically, words start with upper cased
characters and all remaining
On 2017/01/16 01:10:48, vadmium wrote:
> As an adjective, I think this has to be one word: either “upper-cased
> characters” or “uppercased characters”.

Done.

http://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c#newcod...
Objects/unicodeobject.c:10770: Return a version of S suitable for caseless
comparisons.
On 2017/01/16 01:10:48, vadmium wrote:
> S is no longer defined. Also applies to __format__().

Done.

http://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c#newcod...
Objects/unicodeobject.c:11502: The error handling scheme to use for the handling
of encoding errors.
On 2017/01/16 01:10:48, vadmium wrote:
> Simplify: The error handling scheme to use for encoding errors.

Done.

http://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c#newcod...
Objects/unicodeobject.c:11508: Encode a string using the codec registered for
encoding.
On 2017/01/16 01:10:48, vadmium wrote:
> More specific: Encode the string . . .

Done.

http://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c#newcod...
Objects/unicodeobject.c:11725: Return whether the string is a lowercase string;
False otherwise.
On 2017/01/16 01:10:48, vadmium wrote:
> Either drop “False otherwise”, or restore “True if . . .”.
> 
> I think a comma (,) would be better than a semicolon (;). This also applies to
> more methods below.

Done.

http://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c#newcod...
Objects/unicodeobject.c:11996: A string is a digit string if all characters in
the string are decimal and
On 2017/01/16 01:10:48, vadmium wrote:
> Digit string or decimal string?

Done.

http://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c#newcod...
Objects/unicodeobject.c:12073: Return True if the string is an numeric string;
False otherwise.
On 2017/01/16 01:10:48, vadmium wrote:
> a numeric

Done.

http://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c#newcod...
Objects/unicodeobject.c:12206: The string whose method is called is inserted in
between each pair of given
On 2017/01/16 01:10:48, vadmium wrote:
> “Each pair” seems redundant and confusing. Maybe “. . . between each given
> string” would simpler and clearer.

Done.

http://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c#newcod...
Objects/unicodeobject.c:12209: The result is returned as a new string.
On 2017/01/16 01:10:48, vadmium wrote:
> Maybe join this with the previous paragraph?

Done.

http://bugs.python.org/review/20180/diff/19747/Objects/unicodeobject.c#newcod...
Objects/unicodeobject.c:13309: The original string is never truncated.
On 2017/01/16 01:10:48, vadmium wrote:
> Drop “original”

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+