Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(207193)

#20151: Convert the binascii module to use Argument Clinic

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by storchaka+cpython
Modified:
5 years, 11 months ago
Reviewers:
larry
CC:
larry, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 10

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Modules/binascii.c View 1 2 41 chunks +306 lines, -294 lines 0 comments Download
Modules/binascii.clinic.c View 1 2 1 chunk +429 lines, -0 lines 0 comments Download

Messages

Total messages: 3
larry
Patch looked great, minor stuff. Thanks! http://bugs.python.org/review/20151/diff/10488/Modules/binascii.c File Modules/binascii.c (right): http://bugs.python.org/review/20151/diff/10488/Modules/binascii.c#newcode1136 Modules/binascii.c:1136: crc: unsigned_int(bitwise=True) The ...
5 years, 11 months ago #1
storchaka_gmail.com
http://bugs.python.org/review/20151/diff/10488/Modules/binascii.c File Modules/binascii.c (right): http://bugs.python.org/review/20151/diff/10488/Modules/binascii.c#newcode1136 Modules/binascii.c:1136: crc: unsigned_int(bitwise=True) On 2014/01/09 21:35:43, larry wrote: > The ...
5 years, 11 months ago #2
larry
5 years, 11 months ago #3
Not a full review, just responding to one thing.

http://bugs.python.org/review/20151/diff/10488/Modules/binascii.c
File Modules/binascii.c (right):

http://bugs.python.org/review/20151/diff/10488/Modules/binascii.c#newcode1136
Modules/binascii.c:1136: crc: unsigned_int(bitwise=True)
On 2014/01/11 21:34:46, storchaka wrote:
> The format string was 'i', but the variable type was unsigned int.

Right.  So what happens if someone has existing code that calls crc_hqx(buffer,
-1)?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+