Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(650)

#20059: Inconsistent urlparse/urllib.parse handling of invalid port values?

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by chad.birch
Modified:
2 years, 2 months ago
Reviewers:
storchaka, senthil
CC:
orsenthil, rbcollins, r.david.murray, cvrebert, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, storchaka, demian, chad.birch_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Patch Set 3 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/urllib.parse.rst View 1 2 3 chunks +14 lines, -4 lines 0 comments Download
Doc/whatsnew/3.6.rst View 1 2 1 chunk +4 lines, -1 line 1 comment Download
Lib/test/test_urlparse.py View 1 2 1 chunk +17 lines, -19 lines 0 comments Download
Lib/urllib/parse.py View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2
storchaka_gmail.com
http://bugs.python.org/review/20059/diff/13888/Lib/test/test_urlparse.py File Lib/test/test_urlparse.py (right): http://bugs.python.org/review/20059/diff/13888/Lib/test/test_urlparse.py#newcode574 Lib/test/test_urlparse.py:574: self.assertRaises(ValueError, lambda: p.port) Will be better to use context ...
2 years, 7 months ago #1
orsenthil
2 years, 2 months ago #2
LGTM. 

I see that you have already incorporated stochaka's review comments.

http://bugs.python.org/review/20059/diff/15300/Doc/whatsnew/3.6.rst
File Doc/whatsnew/3.6.rst (right):

http://bugs.python.org/review/20059/diff/15300/Doc/whatsnew/3.6.rst#newcode167
Doc/whatsnew/3.6.rst:167: now raises :exc:`ValueError` for out-of-range values,
rather than
s/now raises/raises/
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7