Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(96010)

#19990: Add unittests for imghdr module

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by pcmanticore
Modified:
5 years, 7 months ago
Reviewers:
sky.kok
CC:
Claudiu.Popa, devnull_psf.upfronthosting.co.za, storchaka, vajrasky, mvignali
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/imghdrdata/python.pbm View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
Lib/test/imghdrdata/python.xbm View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
Lib/test/test_imghdr.py View 1 2 3 4 1 chunk +113 lines, -0 lines 0 comments Download
Lib/test/test_sundry.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
vajrasky
5 years, 8 months ago #1
http://bugs.python.org/review/19990/diff/10340/Lib/test/test_imghdr.py
File Lib/test/test_imghdr.py (right):

http://bugs.python.org/review/19990/diff/10340/Lib/test/test_imghdr.py#newcode21
Lib/test/test_imghdr.py:21: 
2 blank lines, please.

http://bugs.python.org/review/19990/diff/10340/Lib/test/test_imghdr.py#newcode37
Lib/test/test_imghdr.py:37: self.assertEqual(imghdr.what(TESTFN),
We need one kind of test that tests the file object input, not just string
(TESTFN is a string).
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+