Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(84884)

#19974: tarfile doesn't overwrite symlink by directory

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by antonymayi
Modified:
8 months, 1 week ago
Reviewers:
storchaka, sky.kok, pcmanticore, vadmium+py
CC:
jcea, lars.gustaebel, haypo, Martin Panter, storchaka, vajrasky, antonymayi_yahoo.com, drpotato
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 10

Patch Set 4 #

Patch Set 5 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/tarfile.py View 1 2 3 4 3 chunks +15 lines, -1 line 2 comments Download
Lib/test/test_tarfile.py View 1 2 3 4 3 chunks +152 lines, -7 lines 1 comment Download

Messages

Total messages: 5
storchaka_gmail.com
http://bugs.python.org/review/19974/diff/10333/Lib/tarfile.py File Lib/tarfile.py (right): http://bugs.python.org/review/19974/diff/10333/Lib/tarfile.py#newcode1999 Lib/tarfile.py:1999: drv, normalized_path = os.path.splitdrive(path) Why these changes are needed? ...
5 years, 8 months ago #1
vajrasky
http://bugs.python.org/review/19974/diff/10333/Lib/tarfile.py File Lib/tarfile.py (right): http://bugs.python.org/review/19974/diff/10333/Lib/tarfile.py#newcode1999 Lib/tarfile.py:1999: drv, normalized_path = os.path.splitdrive(path) On 2013/12/15 21:38:11, storchaka wrote: ...
5 years, 7 months ago #2
storchaka_gmail.com
http://bugs.python.org/review/19974/diff/10333/Lib/tarfile.py File Lib/tarfile.py (right): http://bugs.python.org/review/19974/diff/10333/Lib/tarfile.py#newcode1999 Lib/tarfile.py:1999: drv, normalized_path = os.path.splitdrive(path) On 2014/01/16 08:21:52, vajrasky wrote: ...
5 years, 7 months ago #3
Claudiu.Popa
http://bugs.python.org/review/19974/diff/11106/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): http://bugs.python.org/review/19974/diff/11106/Lib/test/test_tarfile.py#newcode1204 Lib/test/test_tarfile.py:1204: tar = tarfile.open(temparchive,'w') I guess the code could be ...
5 years, 5 months ago #4
Martin Panter
8 months, 1 week ago #5
https://bugs.python.org/review/19974/diff/11106/Lib/tarfile.py
File Lib/tarfile.py (right):

https://bugs.python.org/review/19974/diff/11106/Lib/tarfile.py#newcode50
Lib/tarfile.py:50: import errno
What is this needed for?

https://bugs.python.org/review/19974/diff/11106/Lib/tarfile.py#newcode2089
Lib/tarfile.py:2089: if os.path.exists(targetpath) and \
What about “lexists” for handling broken links? See
<https://bugs.python.org/issue12088>.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+