Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(158982)

#19967: asyncio: remove _TracebackLogger

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 12 months ago by vstinner
Modified:
5 years, 11 months ago
Reviewers:
pitrou, guido
CC:
gvanrossum, AntoinePitrou, haypo, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 8

Patch Set 3 #

Patch Set 4 #

Total comments: 4

Patch Set 5 #

Patch Set 6 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/asyncio/futures.py View 1 2 3 4 5 5 chunks +17 lines, -11 lines 1 comment Download

Messages

Total messages: 5
AntoinePitrou
http://bugs.python.org/review/19967/diff/10300/Lib/asyncio/futures.py File Lib/asyncio/futures.py (right): http://bugs.python.org/review/19967/diff/10300/Lib/asyncio/futures.py#newcode21 Lib/asyncio/futures.py:21: PY34 = sys.version_info >= (3, 4) _PY34 perhaps. http://bugs.python.org/review/19967/diff/10300/Lib/asyncio/futures.py#newcode169 ...
5 years, 11 months ago #1
victor.stinner_gmail.com
http://bugs.python.org/review/19967/diff/10300/Lib/asyncio/futures.py File Lib/asyncio/futures.py (right): http://bugs.python.org/review/19967/diff/10300/Lib/asyncio/futures.py#newcode21 Lib/asyncio/futures.py:21: PY34 = sys.version_info >= (3, 4) On 2013/12/13 01:17:13, ...
5 years, 11 months ago #2
gvanrossum
http://bugs.python.org/review/19967/diff/10300/Lib/asyncio/futures.py File Lib/asyncio/futures.py (right): http://bugs.python.org/review/19967/diff/10300/Lib/asyncio/futures.py#newcode21 Lib/asyncio/futures.py:21: PY34 = sys.version_info >= (3, 4) On 2013/12/13 03:46:11, ...
5 years, 11 months ago #3
gvanrossum
http://bugs.python.org/review/19967/diff/10383/Lib/asyncio/futures.py File Lib/asyncio/futures.py (right): http://bugs.python.org/review/19967/diff/10383/Lib/asyncio/futures.py#newcode137 Lib/asyncio/futures.py:137: _tb_logger = None You could just define both unconditionally ...
5 years, 11 months ago #4
gvanrossum
5 years, 11 months ago #5
http://bugs.python.org/review/19967/diff/10391/Lib/asyncio/futures.py
File Lib/asyncio/futures.py (right):

http://bugs.python.org/review/19967/diff/10391/Lib/asyncio/futures.py#newcode179
Lib/asyncio/futures.py:179: logger.error('Future/Task exception was never
retrieved:\n%s',
You shouldn't need format_exception() -- you can use logging.error(msg,
exc_info=...) and it'll format the exception for you.  The exc_info argument
must be the tuple (exc.__class__, exc, exc.__traceback__).
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+