Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(256876)

#19946: Have multiprocessing raise ImportError when spawning a process that can't find the "main" module

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by olivier.grisel
Modified:
5 years, 8 months ago
Reviewers:
shibturn, ncoghlan
CC:
brett.cannon, Nick Coghlan, AntoinePitrou, larry, christian.heimes, devnull_psf.upfronthosting.co.za, sbt, eric.snow, Zach Ware, Olivier.Grisel
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 2

Patch Set 4 #

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_multiprocessing_main_handling.py View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
sbt
http://bugs.python.org/review/19946/diff/10345/Lib/multiprocessing/spawn.py File Lib/multiprocessing/spawn.py (right): http://bugs.python.org/review/19946/diff/10345/Lib/multiprocessing/spawn.py#newcode256 Lib/multiprocessing/spawn.py:256: if 0 and main_name == 'ipython': Should the "0 ...
5 years, 8 months ago #1
Nick Coghlan
5 years, 8 months ago #2
http://bugs.python.org/review/19946/diff/10345/Lib/multiprocessing/spawn.py
File Lib/multiprocessing/spawn.py (right):

http://bugs.python.org/review/19946/diff/10345/Lib/multiprocessing/spawn.py#n...
Lib/multiprocessing/spawn.py:256: if 0 and main_name == 'ipython':
On 2013/12/17 00:16:22, sbt wrote:
> Should the "0 and " in the test be removed?

Oops, that's a legacy of trying to force the test of the workaround to fail to
make sure the workaround was actually needed and is doing the right thing.

That workaround test is covering similar behaviour to what I need to check for
the spawn and forkserver cases, so I'll clean all this up tonight (I always want
to check what the results are for the new test case without patching anything at
all so I can add an appropriate entry to What's New)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+