Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

#19925: Add unit test for spwd module

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by sky.kok
Modified:
5 years, 8 months ago
Reviewers:
pcmanticore, storchaka, berker.peksag
CC:
Claudiu.Popa, devnull_psf.upfronthosting.co.za, storchaka, vajrasky
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Total comments: 4

Patch Set 3 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_spwd.py View 1 2 1 chunk +48 lines, -0 lines 1 comment Download

Messages

Total messages: 5
Claudiu.Popa
http://bugs.python.org/review/19925/diff/10241/Lib/test/test_spwd.py File Lib/test/test_spwd.py (right): http://bugs.python.org/review/19925/diff/10241/Lib/test/test_spwd.py#newcode6 Lib/test/test_spwd.py:6: return os.getuid() == 0 You should check that `os` ...
6 years, 1 month ago #1
Claudiu.Popa
http://bugs.python.org/review/19925/diff/10245/Lib/test/test_spwd.py File Lib/test/test_spwd.py (right): http://bugs.python.org/review/19925/diff/10245/Lib/test/test_spwd.py#newcode27 Lib/test/test_spwd.py:27: self.assertTrue(isinstance(entry, spwd.struct_spwd)) Isn't `self.assertIsInstance(entry, spwd.struct_spwd)` clearer?
5 years, 10 months ago #2
storchaka_gmail.com
http://bugs.python.org/review/19925/diff/10245/Lib/test/test_spwd.py File Lib/test/test_spwd.py (right): http://bugs.python.org/review/19925/diff/10245/Lib/test/test_spwd.py#newcode16 Lib/test/test_spwd.py:16: @unittest.skipUnless(has_spwd_and_is_root(), It would be better to split this on ...
5 years, 8 months ago #3
storchaka_gmail.com
http://bugs.python.org/review/19925/diff/10245/Lib/test/test_spwd.py File Lib/test/test_spwd.py (right): http://bugs.python.org/review/19925/diff/10245/Lib/test/test_spwd.py#newcode6 Lib/test/test_spwd.py:6: import spwd Actually we have special helper function for ...
5 years, 8 months ago #4
berkerpeksag
5 years, 8 months ago #5
http://bugs.python.org/review/19925/diff/11945/Lib/test/test_spwd.py
File Lib/test/test_spwd.py (right):

http://bugs.python.org/review/19925/diff/11945/Lib/test/test_spwd.py#newcode8
Lib/test/test_spwd.py:8: @unittest.skipIf(spwd is None, "Needs spwd module")
You could remove this line. support.import_module already raises a
unittest.skipTest() exception if the module cannot be found.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+