Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(80917)

#19776: Provide expanduser() on Path objects

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by pitrou
Modified:
4 years, 3 months ago
Reviewers:
berker.peksag, pcmanticore, storchaka
CC:
AntoinePitrou, haypo, Arfrever, cvrebert, Charles-Fran├žois Natali, Claudiu.Popa, devnull_psf.upfronthosting.co.za, Zach Ware, storchaka, steve.dower, dje.gcc_gmail.com, vajrasky, seirl, fletcher_tomalty.com, infroma_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 3

Patch Set 3 #

Total comments: 6

Patch Set 4 #

Total comments: 15

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Total comments: 7

Patch Set 8 #

Total comments: 1

Patch Set 9 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_pathlib.py View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15
berkerpeksag
http://bugs.python.org/review/19776/diff/10200/Doc/library/pathlib.rst File Doc/library/pathlib.rst (right): http://bugs.python.org/review/19776/diff/10200/Doc/library/pathlib.rst#newcode892 Doc/library/pathlib.rst:892: >>> p = PosixPath('~root') What about using something like ...
4 years, 11 months ago #1
AntoinePitrou
Just to add a bit to Berker's review (thank you, by the way!), I'm wondering ...
4 years, 11 months ago #2
AntoinePitrou
Thanks for the patch. For the record, did you run the tests under Windows? I ...
4 years, 10 months ago #3
Claudiu.Popa
On 2014/06/17 02:24:12, AntoinePitrou wrote: > Thanks for the patch. For the record, did you ...
4 years, 10 months ago #4
Claudiu.Popa
http://bugs.python.org/review/19776/diff/11860/Lib/test/test_pathlib.py File Lib/test/test_pathlib.py (right): http://bugs.python.org/review/19776/diff/11860/Lib/test/test_pathlib.py#newcode1264 Lib/test/test_pathlib.py:1264: @unittest.skipUnless(os.name == 'posix', On 2014/06/17 02:24:12, AntoinePitrou wrote: > ...
4 years, 10 months ago #5
storchaka_gmail.com
http://bugs.python.org/review/19776/diff/12192/Doc/library/pathlib.rst File Doc/library/pathlib.rst (right): http://bugs.python.org/review/19776/diff/12192/Doc/library/pathlib.rst#newcode947 Doc/library/pathlib.rst:947: PosixPath('/home/ericidle/films') This example looks misleading. Usually user directories are ...
4 years, 9 months ago #6
storchaka_gmail.com
http://bugs.python.org/review/19776/diff/12192/Lib/pathlib.py File Lib/pathlib.py (right): http://bugs.python.org/review/19776/diff/12192/Lib/pathlib.py#newcode979 Lib/pathlib.py:979: return self.__class__(os.path.expanduser(str(self))) And main. WindowsPath should call ntpath.expanduser(), and ...
4 years, 9 months ago #7
Claudiu.Popa
http://bugs.python.org/review/19776/diff/12192/Doc/library/pathlib.rst File Doc/library/pathlib.rst (right): http://bugs.python.org/review/19776/diff/12192/Doc/library/pathlib.rst#newcode947 Doc/library/pathlib.rst:947: PosixPath('/home/ericidle/films') On 2014/07/15 13:40:23, storchaka wrote: > This example ...
4 years, 9 months ago #8
storchaka_gmail.com
http://bugs.python.org/review/19776/diff/12192/Lib/pathlib.py File Lib/pathlib.py (right): http://bugs.python.org/review/19776/diff/12192/Lib/pathlib.py#newcode979 Lib/pathlib.py:979: return self.__class__(os.path.expanduser(str(self))) On 2014/07/15 16:23:23, Claudiu.Popa wrote: > On ...
4 years, 9 months ago #9
Claudiu.Popa
On 2014/07/15 20:53:38, storchaka wrote: > http://bugs.python.org/review/19776/diff/12192/Lib/pathlib.py > File Lib/pathlib.py (right): > > http://bugs.python.org/review/19776/diff/12192/Lib/pathlib.py#newcode979 > ...
4 years, 9 months ago #10
Claudiu.Popa
4 years, 9 months ago #11
AntoinePitrou
http://bugs.python.org/review/19776/diff/12499/Lib/pathlib.py File Lib/pathlib.py (right): http://bugs.python.org/review/19776/diff/12499/Lib/pathlib.py#newcode242 Lib/pathlib.py:242: if parts[-1] != os.environ['USERNAME']: Can you add a comment ...
4 years, 8 months ago #12
storchaka_gmail.com
http://bugs.python.org/review/19776/diff/12499/Lib/pathlib.py File Lib/pathlib.py (right): http://bugs.python.org/review/19776/diff/12499/Lib/pathlib.py#newcode242 Lib/pathlib.py:242: if parts[-1] != os.environ['USERNAME']: On 2014/08/13 01:40:13, AntoinePitrou wrote: ...
4 years, 8 months ago #13
AntoinePitrou
Sorry, had forgotten to reply. It would be nice if you could upload an updated ...
4 years, 7 months ago #14
berkerpeksag
4 years, 7 months ago #15
http://bugs.python.org/review/19776/diff/12901/Lib/test/test_pathlib.py
File Lib/test/test_pathlib.py (right):

http://bugs.python.org/review/19776/diff/12901/Lib/test/test_pathlib.py#newco...
Lib/test/test_pathlib.py:1951: import pwd
Can this be written as

    pwd = support.import_module('pwd')
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+