Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25034)

#19771: runpy should check ImportError.name before wrapping it

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by ncoghlan
Modified:
3 years, 9 months ago
Reviewers:
berker.peksag, luiz.poleto, vadmium+py
CC:
Nick Coghlan, r.david.murray, SilentGhost, devnull_psf.upfronthosting.co.za, eric.snow, Anthony.Kong, berkerpeksag, Martin Panter, Fotis.Koutoulakis, poleto, lac
Visibility:
Public.

Patch Set 1 #

Total comments: 15

Patch Set 2 #

Total comments: 4

Patch Set 3 #

Total comments: 1

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/runpy.py View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
Lib/test/test_cmd_line_script.py View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
Misc/NEWS View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
berkerpeksag
http://bugs.python.org/review/19771/diff/11685/Lib/runpy.py File Lib/runpy.py (right): http://bugs.python.org/review/19771/diff/11685/Lib/runpy.py#newcode110 Lib/runpy.py:110: if type(ex) is ImportError: Please use ``isinstance(ex, ImportError)`` instead. ...
5 years, 5 months ago #1
poleto
http://bugs.python.org/review/19771/diff/11685/Lib/runpy.py File Lib/runpy.py (right): http://bugs.python.org/review/19771/diff/11685/Lib/runpy.py#newcode110 Lib/runpy.py:110: if type(ex) is ImportError: On 2014/04/21 17:34:41, berkerpeksag wrote: ...
5 years, 5 months ago #2
berkerpeksag
http://bugs.python.org/review/19771/diff/11684/Lib/test/test_runpy.py File Lib/test/test_runpy.py (right): http://bugs.python.org/review/19771/diff/11684/Lib/test/test_runpy.py#newcode215 Lib/test/test_runpy.py:215: if write_source: IMHO, this should be handled either in ...
4 years, 6 months ago #3
Martin Panter
https://bugs.python.org/review/19771/diff/11684/Lib/test/test_runpy.py File Lib/test/test_runpy.py (right): https://bugs.python.org/review/19771/diff/11684/Lib/test/test_runpy.py#newcode215 Lib/test/test_runpy.py:215: if write_source: On 2015/03/05 04:55:00, berkerpeksag wrote: > IMHO, ...
4 years, 6 months ago #4
Martin Panter
4 years, 6 months ago #5
https://bugs.python.org/review/19771/diff/11684/Lib/test/test_runpy.py
File Lib/test/test_runpy.py (right):

https://bugs.python.org/review/19771/diff/11684/Lib/test/test_runpy.py#newcod...
Lib/test/test_runpy.py:435: pkg_dir, mod_fname, mod_name, mod_spec = (
On 2015/03/05 04:55:00, berkerpeksag wrote:
> I prefer this style:
> 
> pkg_dir, mod_fname, mod_name, mod_spec = self._make_pkg(
>     source, 1, "__main__", write_source_to_init=write_source
> )

Splitting it into two separate statements in my new patch
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+