Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28784)

#19764: subprocess: use PROC_THREAD_ATTRIBUTE_HANDLE_LIST with STARTUPINFOEX on Windows Vista

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by vstinner
Modified:
2 years, 5 months ago
Reviewers:
eryksun, segev208
CC:
gregory.p.smith, pmoore, haypo, tim.golden, Bernt.Røskar.Brenna, sbt, Zach Ware, eryksun, steve.dower, sebastian.bank_uni-leipzig.de, Segev Finer
Visibility:
Public.

Patch Set 1 #

Total comments: 8

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 2

Patch Set 5 #

Total comments: 10

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/subprocess.rst View 1 2 3 4 5 2 chunks +21 lines, -5 lines 0 comments Download
Lib/subprocess.py View 1 2 3 4 5 4 chunks +50 lines, -14 lines 0 comments Download
Lib/test/test_subprocess.py View 1 2 3 4 5 2 chunks +50 lines, -5 lines 0 comments Download
Modules/clinic/_winapi.c.h View 1 2 3 4 5 1 chunk +35 lines, -1 line 0 comments Download
Modules/_winapi.c View 1 2 3 4 5 5 chunks +217 lines, -25 lines 0 comments Download

Messages

Total messages: 7
eryksun
http://bugs.python.org/review/19764/diff/19658/Lib/subprocess.py File Lib/subprocess.py (right): http://bugs.python.org/review/19764/diff/19658/Lib/subprocess.py#newcode615 Lib/subprocess.py:615: close_fds = True This conditional assignment is now the ...
2 years, 8 months ago #1
eryksun
http://bugs.python.org/review/19764/diff/19737/Lib/subprocess.py File Lib/subprocess.py (right): http://bugs.python.org/review/19764/diff/19737/Lib/subprocess.py#newcode950 Lib/subprocess.py:950: handle_list = [handle for handle in handle_list if handle ...
2 years, 5 months ago #2
Segev Finer
On 2017/04/19 08:18:35, eryksun wrote: > http://bugs.python.org/review/19764/diff/19737/Lib/subprocess.py > File Lib/subprocess.py (right): > > http://bugs.python.org/review/19764/diff/19737/Lib/subprocess.py#newcode950 > ...
2 years, 5 months ago #3
Segev Finer
On 2017/04/19 08:18:35, eryksun wrote: > http://bugs.python.org/review/19764/diff/19737/Lib/subprocess.py > File Lib/subprocess.py (right): > > http://bugs.python.org/review/19764/diff/19737/Lib/subprocess.py#newcode950 > ...
2 years, 5 months ago #4
eryksun
http://bugs.python.org/review/19764/diff/20017/Doc/library/subprocess.rst File Doc/library/subprocess.rst (right): http://bugs.python.org/review/19764/diff/20017/Doc/library/subprocess.rst#newcode451 Doc/library/subprocess.rst:451: On Windows, if *close_fds* is true then no handles ...
2 years, 5 months ago #5
Segev Finer
(Replied inline) On 2017/04/20 07:56:17, eryksun wrote: > http://bugs.python.org/review/19764/diff/20017/Doc/library/subprocess.rst > File Doc/library/subprocess.rst (right): > > ...
2 years, 5 months ago #6
Segev Finer
2 years, 5 months ago #7
Note that I submitted another patch with more fixes now that I figured out that
Python moved to GitHub LOL. I just hope that this review system doesn't choke
since this patch is now created with git diff. If it does than I can try
re-submitting as a GitHub PR.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+