Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4072)

#19714: Add tests for importlib.machinery.WindowsRegistryFinder

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by brett
Modified:
4 years, 9 months ago
Reviewers:
martin, ericsnowcurrently
CC:
loewis, brett.cannon, Nick Coghlan, Arfrever, Claudiu.Popa, BreamoreBoy, devnull_psf.upfronthosting.co.za, eric.snow, Jim.J.Jewett, vajrasky
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Total comments: 1

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_importlib/test_windows.py View 1 2 3 2 chunks +63 lines, -2 lines 0 comments Download

Messages

Total messages: 2
loewis
http://bugs.python.org/review/19714/diff/11384/Lib/test/test_importlib/test_windows.py File Lib/test/test_importlib/test_windows.py (right): http://bugs.python.org/review/19714/diff/11384/Lib/test/test_importlib/test_windows.py#newcode57 Lib/test/test_importlib/test_windows.py:57: test_module = "spamham{}".format(os.getpid()) I would add a comment here ...
5 years ago #1
eric.snow
5 years ago #2
I'm not too familiar with the registry stuff so I'll defer to Martin on that. 
Otherwise it looks good to me.  Thanks for working on this.

http://bugs.python.org/review/19714/diff/11387/Lib/test/test_importlib/test_w...
File Lib/test/test_importlib/test_windows.py (right):

http://bugs.python.org/review/19714/diff/11387/Lib/test/test_importlib/test_w...
Lib/test/test_importlib/test_windows.py:18: def delete_tree(root, subkey):
Perhaps "delete_registry_tree" just to be clear?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+