Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(86230)

#19662: smtpd.py should not decode utf-8

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 12 months ago by polzer
Modified:
5 years, 5 months ago
Reviewers:
berker.peksag, rdmurray
CC:
barry, richard_python.org, haypo, Arfrever, r.david.murray, jesstess, devnull_psf.upfronthosting.co.za, maciej.szulik, lpolzer, illirgway_gmail.com, dukedougal_gmail.com, zvyn, sreepriya
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 3

Patch Set 3 #

Patch Set 4 #

Total comments: 6

Patch Set 5 #

Total comments: 2

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/smtpd.rst View 1 2 3 4 5 4 chunks +8 lines, -2 lines 0 comments Download
Lib/smtpd.py View 1 2 3 4 5 7 chunks +30 lines, -9 lines 0 comments Download
Lib/test/test_smtpd.py View 1 2 3 4 5 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 3
berkerpeksag
http://bugs.python.org/review/19662/diff/11491/Lib/smtpd.py File Lib/smtpd.py (right): http://bugs.python.org/review/19662/diff/11491/Lib/smtpd.py#newcode139 Lib/smtpd.py:139: self.decode_data = True You also need to add a ...
5 years, 7 months ago #1
r.david.murray
http://bugs.python.org/review/19662/diff/11979/Lib/smtpd.py File Lib/smtpd.py (right): http://bugs.python.org/review/19662/diff/11979/Lib/smtpd.py#newcode103 Lib/smtpd.py:103: UTF8_ENCODING = 'utf-8' This constant is more confusing than ...
5 years, 5 months ago #2
lpolzer
5 years, 5 months ago #3
minor nits in the rst

http://bugs.python.org/review/19662/diff/11991/Doc/library/smtpd.rst
File Doc/library/smtpd.rst (right):

http://bugs.python.org/review/19662/diff/11991/Doc/library/smtpd.rst#newcode116
Doc/library/smtpd.rst:116: *decode_data* specifies weather data should be
decoded using UTF-8. By
spelling: "whether"

http://bugs.python.org/review/19662/diff/11991/Doc/library/smtpd.rst#newcode117
Doc/library/smtpd.rst:117: default it is True, but this will change in future
versions.
Suggest "The default is True, [...]"
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+