Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(202393)

#19628: maxlevels -1 on compileall for unlimited recursion

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by sworddragon2
Modified:
5 years, 8 months ago
Reviewers:
berker.peksag
CC:
Benjamin Peterson, r.david.murray, Claudiu.Popa, sworddragon2_gmail.com, devnull_psf.upfronthosting.co.za, berkerpeksag
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/compileall.rst View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
Lib/compileall.py View 1 2 3 chunks +11 lines, -1 line 0 comments Download
Lib/test/test_compileall.py View 1 2 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 1
berkerpeksag
5 years, 8 months ago #1
http://bugs.python.org/review/19628/diff/11266/Lib/compileall.py
File Lib/compileall.py (right):

http://bugs.python.org/review/19628/diff/11266/Lib/compileall.py#newcode173
Lib/compileall.py:173: parser.add_argument('-r', action='store',
Using ``action='store'`` is redundant here.

http://bugs.python.org/review/19628/diff/11266/Lib/test/test_compileall.py
File Lib/test/test_compileall.py (right):

http://bugs.python.org/review/19628/diff/11266/Lib/test/test_compileall.py#ne...
Lib/test/test_compileall.py:280: os.makedirs(subpackage3)
Can you use script_helper.make_pkg instead of os.makedirs here?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+