Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

#19611: inspect.getcallargs doesn't properly interpret set comprehension code objects.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by ned
Modified:
1 year, 6 months ago
Reviewers:
rdmurray
CC:
Nick Coghlan, nedbat, r.david.murray, devnull_psf.upfronthosting.co.za, storchaka, Yury Selivanov, Jelle Zijlstra
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/inspect.rst View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
Lib/inspect.py View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
Lib/test/test_inspect.py View 1 2 3 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 1
r.david.murray
1 year, 6 months ago #1
I wonder if we should mark the tests as being tests of a cpython implementation
detail.

http://bugs.python.org/review/19611/diff/17466/Doc/library/inspect.rst
File Doc/library/inspect.rst (right):

http://bugs.python.org/review/19611/diff/17466/Doc/library/inspect.rst#newcod...
Doc/library/inspect.rst:636: ``implicit0``.
How about:

.. impl-detail::

   .. versionchanged:: 3.6
      Parameter now supports the non-identifier argument
      names of the form ``.0`` that CPython generates
      internally for comprehension and generator code
      objects and exposes them in the form ``implicit0``.

http://bugs.python.org/review/19611/diff/17466/Lib/inspect.py
File Lib/inspect.py (right):

http://bugs.python.org/review/19611/diff/17466/Lib/inspect.py#newcode2400
Lib/inspect.py:2400: # These are implicit arguments generated by comprehensions.
In
"These are arguments implicitly generated by the CPython compiler for
comprehensions and generators..."
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7