Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(36122)

Unified Diff: Lib/distutils/tests/test_msvc9compiler.py

Issue 19600: Use specific asserts in distutils tests
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
--- a/Lib/distutils/tests/test_msvc9compiler.py Thu Nov 14 23:50:51 2013 +0200
+++ b/Lib/distutils/tests/test_msvc9compiler.py Fri Nov 15 09:27:30 2013 +0200
@@ -128,7 +128,7 @@
# windows registeries versions.
path = r'Control Panel\Desktop'
v = Reg.get_value(path, 'dragfullwindows')
- self.assertTrue(v in ('0', '1', '2'))
+ self.assertIn(v, ('0', '1', '2'))
import winreg
HKCU = winreg.HKEY_CURRENT_USER
@@ -136,7 +136,7 @@
self.assertEqual(keys, None)
keys = Reg.read_keys(HKCU, r'Control Panel')
- self.assertTrue('Desktop' in keys)
+ self.assertIn('Desktop', keys)
def test_remove_visual_c_ref(self):
from distutils.msvc9compiler import MSVCCompiler
@@ -174,7 +174,7 @@
compiler = MSVCCompiler()
got = compiler._remove_visual_c_ref(manifest)
- self.assertIs(got, None)
+ self.assertIsNone(got)
def test_suite():

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+