Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17486)

Unified Diff: Lib/distutils/tests/test_install_scripts.py

Issue 19600: Use specific asserts in distutils tests
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
--- a/Lib/distutils/tests/test_install_scripts.py Thu Nov 14 23:50:51 2013 +0200
+++ b/Lib/distutils/tests/test_install_scripts.py Fri Nov 15 09:27:30 2013 +0200
@@ -24,10 +24,10 @@
skip_build=1,
)
cmd = install_scripts(dist)
- self.assertTrue(not cmd.force)
- self.assertTrue(not cmd.skip_build)
- self.assertTrue(cmd.build_dir is None)
- self.assertTrue(cmd.install_dir is None)
+ self.assertFalse(cmd.force)
+ self.assertFalse(cmd.skip_build)
+ self.assertIsNone(cmd.build_dir)
+ self.assertIsNone(cmd.install_dir)
cmd.finalize_options()
@@ -72,7 +72,7 @@
installed = os.listdir(target)
for name in expected:
- self.assertTrue(name in installed)
+ self.assertIn(name, installed)
def test_suite():

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+