Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32708)

Unified Diff: Lib/distutils/tests/test_build_scripts.py

Issue 19600: Use specific asserts in distutils tests
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
--- a/Lib/distutils/tests/test_build_scripts.py Thu Nov 14 23:50:51 2013 +0200
+++ b/Lib/distutils/tests/test_build_scripts.py Fri Nov 15 09:27:30 2013 +0200
@@ -17,8 +17,8 @@
def test_default_settings(self):
cmd = self.get_build_scripts_cmd("/foo/bar", [])
- self.assertTrue(not cmd.force)
- self.assertTrue(cmd.build_dir is None)
+ self.assertFalse(cmd.force)
+ self.assertIsNone(cmd.build_dir)
cmd.finalize_options()
@@ -38,7 +38,7 @@
built = os.listdir(target)
for name in expected:
- self.assertTrue(name in built)
+ self.assertIn(name, built)
def get_build_scripts_cmd(self, target, scripts):
import sys
@@ -103,7 +103,7 @@
built = os.listdir(target)
for name in expected:
- self.assertTrue(name in built)
+ self.assertIn(name, built)
def test_suite():
return unittest.makeSuite(BuildScriptsTestCase)

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+