Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(248031)

#19600: Use specific asserts in distutils tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by storchaka+cpython
Modified:
5 years, 9 months ago
Reviewers:
ezio.melotti
CC:
tarek_ziade.org, ezio.melotti, eric.araujo, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/distutils/tests/test_archive_util.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/distutils/tests/test_bdist_rpm.py View 2 chunks +2 lines, -2 lines 0 comments Download
Lib/distutils/tests/test_bdist_wininst.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/distutils/tests/test_build_clib.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/distutils/tests/test_build_ext.py View 5 chunks +8 lines, -8 lines 0 comments Download
Lib/distutils/tests/test_build_scripts.py View 3 chunks +4 lines, -4 lines 0 comments Download
Lib/distutils/tests/test_clean.py View 1 chunk +1 line, -1 line 2 comments Download
Lib/distutils/tests/test_config_cmd.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/distutils/tests/test_config.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/distutils/tests/test_install_lib.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/distutils/tests/test_install.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/distutils/tests/test_install_scripts.py View 2 chunks +5 lines, -5 lines 0 comments Download
Lib/distutils/tests/test_msvc9compiler.py View 3 chunks +3 lines, -3 lines 0 comments Download
Lib/distutils/tests/test_register.py View 4 chunks +4 lines, -4 lines 0 comments Download
Lib/distutils/tests/test_sysconfig.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/distutils/tests/test_util.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
ezio.melotti
http://bugs.python.org/review/19600/diff/9920/Lib/distutils/tests/test_clean.py File Lib/distutils/tests/test_clean.py (right): http://bugs.python.org/review/19600/diff/9920/Lib/distutils/tests/test_clean.py#newcode40 Lib/distutils/tests/test_clean.py:40: '%s was not removed' % path) You could fix ...
5 years, 9 months ago #1
storchaka_gmail.com
5 years, 9 months ago #2
http://bugs.python.org/review/19600/diff/9920/Lib/distutils/tests/test_clean.py
File Lib/distutils/tests/test_clean.py (right):

http://bugs.python.org/review/19600/diff/9920/Lib/distutils/tests/test_clean....
Lib/distutils/tests/test_clean.py:40: '%s was not removed' % path)
On 2013/11/16 22:56:04, ezio.melotti wrote:
> You could fix the indentation of this line while you are at it.

Sorry, I missed this comment.

I hadn't fixed the indentation at first place because it was already broken.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+