Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(156847)

#19527: Test failures with COUNT_ALLOCS

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by slavek.kabrda
Modified:
4 years, 7 months ago
Reviewers:
pitrou, storchaka
CC:
haypo, devnull_psf.upfronthosting.co.za, storchaka, bkabrda, rkuska
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 3

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/script_helper.py View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
Lib/test/support/__init__.py View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
Lib/test/test_asyncio/test_events.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_asyncio/test_subprocess.py View 1 2 3 4 4 chunks +4 lines, -0 lines 0 comments Download
Lib/test/test_base64.py View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
Lib/test/test_capi.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_cmd_line.py View 1 2 3 4 4 chunks +4 lines, -0 lines 0 comments Download
Lib/test/test_faulthandler.py View 1 2 3 4 4 chunks +6 lines, -1 line 0 comments Download
Lib/test/test_gc.py View 1 2 3 4 5 chunks +13 lines, -3 lines 0 comments Download
Lib/test/test_httpservers.py View 1 2 3 4 5 chunks +7 lines, -0 lines 0 comments Download
Lib/test/test_io.py View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
Lib/test/test_json/test_tool.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_logging.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_module.py View 1 2 3 4 4 chunks +4 lines, -1 line 0 comments Download
Lib/test/_test_multiprocessing.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_os.py View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
Lib/test/test_pdb.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_platform.py View 1 2 3 4 2 chunks +6 lines, -3 lines 0 comments Download
Lib/test/test_popen.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_quopri.py View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
Lib/test/test_site.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_subprocess.py View 1 2 3 4 39 chunks +41 lines, -1 line 0 comments Download
Lib/test/test_sysconfig.py View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
Lib/test/test_sys.py View 1 2 3 4 8 chunks +21 lines, -10 lines 0 comments Download
Lib/test/test_threading.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_tools/test_pindent.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_traceback.py View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
Lib/test/test_venv.py View 1 2 3 4 5 chunks +6 lines, -1 line 0 comments Download
Lib/test/test_warnings.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_weakref.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/unittest/test/test_runner.py View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3
AntoinePitrou
http://bugs.python.org/review/19527/diff/13393/Lib/test/test_warnings.py File Lib/test/test_warnings.py (right): http://bugs.python.org/review/19527/diff/13393/Lib/test/test_warnings.py#newcode67 Lib/test/test_warnings.py:67: def check_stdout(self, actual, expected): How about handling this in ...
4 years, 7 months ago #1
storchaka_gmail.com
http://bugs.python.org/review/19527/diff/13393/Lib/test/test_warnings.py File Lib/test/test_warnings.py (right): http://bugs.python.org/review/19527/diff/13393/Lib/test/test_warnings.py#newcode67 Lib/test/test_warnings.py:67: def check_stdout(self, actual, expected): On 2014/12/11 22:11:10, AntoinePitrou wrote: ...
4 years, 7 months ago #2
AntoinePitrou
4 years, 7 months ago #3
http://bugs.python.org/review/19527/diff/13393/Lib/test/test_warnings.py
File Lib/test/test_warnings.py (right):

http://bugs.python.org/review/19527/diff/13393/Lib/test/test_warnings.py#newc...
Lib/test/test_warnings.py:67: def check_stdout(self, actual, expected):
On 2014/12/12 10:08:21, storchaka wrote:
> On 2014/12/11 22:11:10, AntoinePitrou wrote:
> > How about handling this in assert_python_ok() instead?
> 
> What do you mean? assert_python_ok() doesn't know anything about expected
> stdout.

assert_python_ok() already calls strip_python_stderr(). There could be a
strip_python_stdout() doing the same thing.

As a side note, I would have expected the counts to be printed on stderr,
perhaps it should be changed.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+