Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(263360)

#19494: urllib2.HTTPBasicAuthHandler (or urllib.request.HTTPBasicAuthHandler) doesn't work with GitHub API

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by mcepl
Modified:
4 years, 11 months ago
Reviewers:
berker.peksag
CC:
arigo, Nick Coghlan, orsenthil, AntoinePitrou, christian.heimes, mcepl, r.david.murray, devnull_psf.upfronthosting.co.za, Rosuav, axitkhurana, icordasc, demian
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/urllib.request.rst View 1 1 chunk +10 lines, -0 lines 0 comments Download
Lib/test/test_urllib2.py View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2
berkerpeksag
The new handler should be documented. See https://docs.python.org/3.4/library/urllib.request.html#urllib.request.HTTPBasicAuthHandler for example. http://bugs.python.org/review/19494/diff/12686/Lib/test/test_urllib2.py File Lib/test/test_urllib2.py (right): http://bugs.python.org/review/19494/diff/12686/Lib/test/test_urllib2.py#newcode1410 ...
4 years, 11 months ago #1
mcepl_redhat.com
4 years, 11 months ago #2
On 2014/09/09 22:43:57, berkerpeksag wrote:
> The new handler should be documented. See
>
https://docs.python.org/3.4/library/urllib.request.html#urllib.request.HTTPBa...
> for example.

Not sure about the style of the text (if I mention HTTPBasicAuthHandler twice,
should I both mentions mark with the role `class`?).

http://bugs.python.org/review/19494/diff/12686/Lib/test/test_urllib2.py
File Lib/test/test_urllib2.py (right):

http://bugs.python.org/review/19494/diff/12686/Lib/test/test_urllib2.py#newco...
Lib/test/test_urllib2.py:1410: self.assertFalse('Authorization' in
http_hand.httpconn.req_headers)
On 2014/09/09 22:43:57, berkerpeksag wrote:
> assertNotIn

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+