Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(59)

#19493: Report skipped ctypes tests as skipped

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by storchaka+cpython
Modified:
6 years, 3 months ago
Reviewers:
zachary.ware
CC:
amaury.forgeotdarc, sasha, meadori, devnull_psf.upfronthosting.co.za, Zach Ware, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 1

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/ctypes/test/__init__.py View 1 2 1 chunk +9 lines, -1 line 0 comments Download
Lib/ctypes/test/test_arrays.py View 1 2 2 chunks +12 lines, -14 lines 0 comments Download
Lib/ctypes/test/test_as_parameter.py View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
Lib/ctypes/test/test_bitfields.py View 1 2 4 chunks +9 lines, -10 lines 0 comments Download
Lib/ctypes/test/test_buffers.py View 1 2 2 chunks +29 lines, -31 lines 0 comments Download
Lib/ctypes/test/test_bytes.py View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
Lib/ctypes/test/test_byteswap.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
Lib/ctypes/test/test_callbacks.py View 1 2 5 chunks +22 lines, -25 lines 0 comments Download
Lib/ctypes/test/test_cast.py View 1 2 2 chunks +6 lines, -9 lines 0 comments Download
Lib/ctypes/test/test_cfuncs.py View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
Lib/ctypes/test/test_checkretval.py View 1 2 2 chunks +6 lines, -9 lines 0 comments Download
Lib/ctypes/test/test_errcheck.py View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
Lib/ctypes/test/test_find.py View 1 2 2 chunks +35 lines, -34 lines 0 comments Download
Lib/ctypes/test/test_functions.py View 1 2 6 chunks +32 lines, -38 lines 0 comments Download
Lib/ctypes/test/test_integers.py View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
Lib/ctypes/test/test_keeprefs.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
Lib/ctypes/test/test_loading.py View 1 2 2 chunks +73 lines, -65 lines 0 comments Download
Lib/ctypes/test/test_macholib.py View 1 2 1 chunk +9 lines, -9 lines 0 comments Download
Lib/ctypes/test/test_memfunctions.py View 1 2 2 chunks +21 lines, -23 lines 0 comments Download
Lib/ctypes/test/test_numbers.py View 1 2 3 chunks +21 lines, -18 lines 0 comments Download
Lib/ctypes/test/test_objects.py View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
Lib/ctypes/test/test_parameters.py View 1 2 4 chunks +6 lines, -13 lines 0 comments Download
Lib/ctypes/test/test_prototypes.py View 1 2 3 chunks +41 lines, -43 lines 0 comments Download
Lib/ctypes/test/test_python_api.py View 1 2 2 chunks +17 lines, -16 lines 0 comments Download
Lib/ctypes/test/test_random_things.py View 1 2 1 chunk +13 lines, -14 lines 0 comments Download
Lib/ctypes/test/test_slicing.py View 1 2 2 chunks +32 lines, -35 lines 0 comments Download
Lib/ctypes/test/test_strings.py View 1 2 6 chunks +63 lines, -63 lines 0 comments Download
Lib/ctypes/test/test_structures.py View 1 2 3 chunks +10 lines, -13 lines 0 comments Download
Lib/ctypes/test/test_unicode.py View 1 2 1 chunk +39 lines, -42 lines 0 comments Download
Lib/ctypes/test/test_values.py View 1 2 2 chunks +52 lines, -49 lines 0 comments Download
Lib/ctypes/test/test_win32.py View 1 2 1 chunk +74 lines, -71 lines 0 comments Download
Lib/ctypes/test/test_wintypes.py View 1 2 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 2
Zach Ware
What's here looks good to me.
6 years, 4 months ago #1
storchaka_gmail.com
6 years, 3 months ago #2
http://bugs.python.org/review/19493/diff/9923/Lib/ctypes/test/test_loading.py
File Lib/ctypes/test/test_loading.py (right):

http://bugs.python.org/review/19493/diff/9923/Lib/ctypes/test/test_loading.py...
Lib/ctypes/test/test_loading.py:31:
@unittest.skipUnless(os.path.basename(libc_name) == "libc.so.6", 'wrong libc
path for test')
basename() will fail when libc_name is None.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+