Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(205289)

#19422: Neither DTLS nor error for SSLSocket.sendto() of UDP socket

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by lists
Modified:
5 years, 11 months ago
Reviewers:
pitrou, sky.kok
CC:
bill.janssen_gmail.com, AntoinePitrou, giampaolo.rodola, christian.heimes, devnull_psf.upfronthosting.co.za, vajrasky
Visibility:
Public.

Patch Set 1 #

Total comments: 8

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/ssl.py View 1 2 chunks +3 lines, -1 line 0 comments Download
Lib/test/test_ssl.py View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2
AntoinePitrou
http://bugs.python.org/review/19422/diff/9808/Lib/ssl.py File Lib/ssl.py (right): http://bugs.python.org/review/19422/diff/9808/Lib/ssl.py#newcode336 Lib/ssl.py:336: if sock.type == SocketType.SOCK_DGRAM: The test won't be hit ...
5 years, 11 months ago #1
vajrasky
5 years, 11 months ago #2
http://bugs.python.org/review/19422/diff/9808/Lib/ssl.py
File Lib/ssl.py (right):

http://bugs.python.org/review/19422/diff/9808/Lib/ssl.py#newcode336
Lib/ssl.py:336: if sock.type == SocketType.SOCK_DGRAM:
On 2013/12/22 21:59:57, AntoinePitrou wrote:
> The test won't be hit if _context is passed.

Yeah, I missed that.

http://bugs.python.org/review/19422/diff/9808/Lib/ssl.py#newcode337
Lib/ssl.py:337: raise ValueError("Python SSL library does not support "
On 2013/12/22 21:59:57, AntoinePitrou wrote:
> I think the error should be NotImplementedError.
> Also, the message could be something like "datagram sockets are unsupported".

Agree.

http://bugs.python.org/review/19422/diff/9808/Lib/test/test_ssl.py
File Lib/test/test_ssl.py (right):

http://bugs.python.org/review/19422/diff/9808/Lib/test/test_ssl.py#newcode542
Lib/test/test_ssl.py:542: def
test_raises_exception_on_wrap_socket_with_sock_dgram(self):
On 2013/12/22 21:59:57, AntoinePitrou wrote:
> A shorter test name sounds better, such as "test_unsupported_dtls".

Agree.

http://bugs.python.org/review/19422/diff/9808/Lib/test/test_ssl.py#newcode544
Lib/test/test_ssl.py:544: s = ssl.wrap_socket(socket.socket(socket.AF_INET,
On 2013/12/22 21:59:57, AntoinePitrou wrote:
> Please also test with a SSLContext.

Sure.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+