Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23)

#19407: PEP 453: update the "Installing Python Modules" documentation

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by ncoghlan
Modified:
5 years, 10 months ago
Reviewers:
merwok
CC:
loewis, Georg, Nick Coghlan, larry, Benjamin Peterson, eric.araujo, devnull_psf.upfronthosting.co.za, dstufft, qwcode_gmail.com, freemium.model_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/conf.py View 1 chunk +2 lines, -2 lines 2 comments Download
Doc/contents.rst View 2 chunks +10 lines, -2 lines 3 comments Download
Doc/distributing/index.rst View 1 chunk +15 lines, -0 lines 0 comments Download
Doc/distutils/index.rst View 1 chunk +3 lines, -3 lines 2 comments Download
Doc/extending/index.rst View 2 chunks +36 lines, -6 lines 2 comments Download
Doc/install/index.rst View 1 chunk +3 lines, -3 lines 0 comments Download
Doc/installing/index.rst View 1 chunk +35 lines, -0 lines 0 comments Download
Doc/library/distutils.rst View 1 chunk +10 lines, -9 lines 0 comments Download
Doc/library/ensurepip.rst View 1 chunk +1 line, -1 line 0 comments Download
Doc/tools/sphinxext/indexcontent.html View 1 chunk +4 lines, -4 lines 2 comments Download
Doc/tutorial/whatnow.rst View 1 chunk +2 lines, -2 lines 0 comments Download
Doc/using/windows.rst View 1 chunk +4 lines, -0 lines 1 comment Download
Doc/whatsnew/3.4.rst View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3
eric.araujo
http://bugs.python.org/review/19407/diff/11224/Doc/conf.py File Doc/conf.py (right): http://bugs.python.org/review/19407/diff/11224/Doc/conf.py#newcode123 Doc/conf.py:123: ('distributing/index', 'distutils.tex', You may want to change the tex ...
5 years, 10 months ago #1
Nick Coghlan
Thanks for review Eric. I agree "Modules" is wrong, but "Projects" isn't quite right either. ...
5 years, 10 months ago #2
eric.araujo
5 years, 10 months ago #3
> I agree "Modules" is wrong, but "Projects" isn't quite right either.

It’s distutils terminology.  Something with a setup.py (and possibly modules
and/or scripts and/or data files) is a project; files on PyPI are distributions
of releases of a project.  Of course, PyPI, pip and other tools use slightly
different terminology.

Agreed to keep “modules” for now.

http://bugs.python.org/review/19407/diff/11224/Doc/contents.rst
File Doc/contents.rst (right):

http://bugs.python.org/review/19407/diff/11224/Doc/contents.rst#newcode25
Doc/contents.rst:25: .. include legacy packaging docs in build
Okay.  I remember my solution caused painfully long lines in the sidebar ToC, so
yours looks better.

http://bugs.python.org/review/19407/diff/11224/Doc/using/windows.rst
File Doc/using/windows.rst (right):

http://bugs.python.org/review/19407/diff/11224/Doc/using/windows.rst#newcode16
Doc/using/windows.rst:16: This looks rather stale to me...
There is an issue about this file with a patch being reviewed by Zachary Ware
right now.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+