Issue 19385: dbm.dumb should be consistent when the database is closed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#19385: dbm.dumb should be consistent when the database is closed

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 6 months ago by pcmanticore

Modified:
4 years, 11 months ago

Reviewers:
sky.kok

CC:
Nick Coghlan, Arfrever, Claudiu.Popa, devnull_psf.upfronthosting.co.za, Jim.J.Jewett, storchaka

Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Created: 4 years, 11 months ago

Download raw patch set

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
		Lib/dbm/dumb.py	View	1 2 3 4 5 6	2 chunks	+19 lines, -8 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

vajrasky

5 years, 5 months ago #1

http://bugs.python.org/review/19385/diff/9773/Lib/test/test_dbm_dumb.py
File Lib/test/test_dbm_dumb.py (right):

http://bugs.python.org/review/19385/diff/9773/Lib/test/test_dbm_dumb.py#newco...
Lib/test/test_dbm_dumb.py:202: "DBM object has already been closed")
It needs one more space. " in "DBM should be under s in str.

http://bugs.python.org/review/19385/diff/9773/Lib/test/test_dbm_dumb.py#newco...
Lib/test/test_dbm_dumb.py:211: "DBM object has already been closed")
It needs one more space. " in "DBM should be under s in str.

Expand All Messages | Collapse All Messages