Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(46108)

#19380: Optimize parsing of regular expressions

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by storchaka+cpython
Modified:
4 years, 11 months ago
Reviewers:
yselivanov, shadowranger+python, pitrou
CC:
AntoinePitrou, haypo, ezio.melotti, mrabarnett, devnull_psf.upfronthosting.co.za, storchaka, Josh.R
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 4

Patch Set 4 #

Total comments: 6

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/sre_parse.py View 1 2 3 4 27 chunks +120 lines, -150 lines 0 comments Download

Messages

Total messages: 6
Yury Selivanov
http://bugs.python.org/review/19380/diff/12893/Lib/sre_parse.py File Lib/sre_parse.py (right): http://bugs.python.org/review/19380/diff/12893/Lib/sre_parse.py#newcode411 Lib/sre_parse.py:411: _REPEATCODES = (MIN_REPEAT, MAX_REPEAT) I would use frozenset here
5 years ago #1
Josh.R
I believe the lazily "instancified" width variable will undo the memory reduction (and improved cache ...
5 years ago #2
storchaka_gmail.com
http://bugs.python.org/review/19380/diff/12893/Lib/sre_parse.py File Lib/sre_parse.py (right): http://bugs.python.org/review/19380/diff/12893/Lib/sre_parse.py#newcode90 Lib/sre_parse.py:90: width = None On 2014/09/19 01:17:35, josh.rosenberg wrote: > ...
5 years ago #3
AntoinePitrou
Looks basically good. A couple suggestions below. http://bugs.python.org/review/19380/diff/12999/Lib/sre_parse.py File Lib/sre_parse.py (right): http://bugs.python.org/review/19380/diff/12999/Lib/sre_parse.py#newcode90 Lib/sre_parse.py:90: class SubPattern: ...
4 years, 11 months ago #4
storchaka_gmail.com
Thank you for the review and suggestions. http://bugs.python.org/review/19380/diff/12999/Lib/sre_parse.py File Lib/sre_parse.py (right): http://bugs.python.org/review/19380/diff/12999/Lib/sre_parse.py#newcode90 Lib/sre_parse.py:90: class SubPattern: ...
4 years, 11 months ago #5
AntoinePitrou
4 years, 11 months ago #6
Looks good to me.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+