Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(94510)

#19292: Make SSLContext.set_default_verify_paths() work on Windows

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by guido
Modified:
5 years, 5 months ago
Reviewers:
pitrou
CC:
gvanrossum, bill.janssen_gmail.com, AntoinePitrou, giampaolo.rodola, christian.heimes, marti_juffo.org, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/ssl.rst View 1 3 chunks +28 lines, -1 line 1 comment Download
Lib/ssl.py View 1 3 chunks +37 lines, -0 lines 2 comments Download
Lib/test/test_ssl.py View 1 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 1
AntoinePitrou
5 years, 5 months ago #1
http://bugs.python.org/review/19292/diff/10060/Doc/library/ssl.rst
File Doc/library/ssl.rst (right):

http://bugs.python.org/review/19292/diff/10060/Doc/library/ssl.rst#newcode686
Doc/library/ssl.rst:686: Flag for TLS web server authentication
AFAICT it's not a flag (can't be ORed)? Also, perhaps explain that "server
authentication" actually means "for client use" (people will get confused)?

http://bugs.python.org/review/19292/diff/10060/Lib/ssl.py
File Lib/ssl.py (right):

http://bugs.python.org/review/19292/diff/10060/Lib/ssl.py#newcode324
Lib/ssl.py:324: windows_cert_stores = ("CA", "ROOT")
This should be a private attribute.

http://bugs.python.org/review/19292/diff/10060/Lib/ssl.py#newcode359
Lib/ssl.py:359: if encoding == "x509_asn":
Don't we do anything if the encoding is different?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+