Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(69947)

#19235: Add a dedicated subclass for recursion errors

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by elazarg
Modified:
5 years, 8 months ago
Reviewers:
pitrou
CC:
Georg, rhettinger, AntoinePitrou, larry, r.david.murray, devnull_psf.upfronthosting.co.za, berkerpeksag, Yury Selivanov, Elaz, levkivskyi
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/c-api/exceptions.rst View 4 chunks +9 lines, -3 lines 0 comments Download
Doc/library/exceptions.rst View 1 chunk +10 lines, -0 lines 0 comments Download
Doc/library/pickle.rst View 1 chunk +1 line, -1 line 0 comments Download
Include/ceval.h View 1 chunk +3 lines, -3 lines 0 comments Download
Include/pyerrors.h View 1 chunk +1 line, -0 lines 0 comments Download
Lib/ctypes/test/test_as_parameter.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/test/exception_hierarchy.txt View 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/list_tests.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/test/pickletester.py View 1 chunk +2 lines, -2 lines 0 comments Download
Lib/test/test_class.py View 1 chunk +2 lines, -2 lines 0 comments Download
Lib/test/test_compile.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_copy.py View 3 chunks +3 lines, -3 lines 0 comments Download
Lib/test/test_descr.py View 2 chunks +3 lines, -3 lines 0 comments Download
Lib/test/test_dictviews.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_exceptions.py View 4 chunks +6 lines, -5 lines 1 comment Download
Lib/test/test_isinstance.py View 1 chunk +5 lines, -5 lines 0 comments Download
Lib/test/test_json/test_recursion.py View 3 chunks +6 lines, -6 lines 0 comments Download
Lib/test/test_richcmp.py View 1 chunk +12 lines, -12 lines 0 comments Download
Lib/test/test_runpy.py View 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_sys.py View 2 chunks +3 lines, -3 lines 0 comments Download
Lib/test/test_threading.py View 1 chunk +1 line, -1 line 0 comments Download
Modules/_pickle.c View 1 chunk +1 line, -1 line 0 comments Download
Modules/_sre.c View 1 chunk +2 lines, -1 line 0 comments Download
Objects/exceptions.c View 6 chunks +13 lines, -6 lines 0 comments Download
Objects/typeobject.c View 1 chunk +1 line, -1 line 0 comments Download
Python/ceval.c View 1 chunk +1 line, -1 line 0 comments Download
Python/errors.c View 1 chunk +1 line, -1 line 0 comments Download
Python/symtable.c View 2 chunks +2 lines, -2 lines 0 comments Download
Tools/scripts/find_recursionlimit.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1
AntoinePitrou
5 years, 8 months ago #1
The patch looks good to me. Just one nit below.

http://bugs.python.org/review/19235/diff/9534/Lib/test/test_exceptions.py
File Lib/test/test_exceptions.py (right):

http://bugs.python.org/review/19235/diff/9534/Lib/test/test_exceptions.py#new...
Lib/test/test_exceptions.py:919: self.fail("RuntimeError not raised")
s/RuntimeError/RecursionError/
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+