Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

#19189: Improve cross-references in pickle documentation.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by storchaka+cpython
Modified:
6 years, 7 months ago
Reviewers:
georg
CC:
AntoinePitrou, Alexandre Vassalotti, docs_python.org, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/pickle.rst View 10 chunks +73 lines, -65 lines 4 comments Download

Messages

Total messages: 4
Georg
http://bugs.python.org/review/19189/diff/9465/Doc/library/pickle.rst File Doc/library/pickle.rst (right): http://bugs.python.org/review/19189/diff/9465/Doc/library/pickle.rst#newcode394 Doc/library/pickle.rst:394: calling :meth:`~.object.__getstate__` is picklable (see section ~object. should never ...
6 years, 7 months ago #1
storchaka_gmail.com
http://bugs.python.org/review/19189/diff/9465/Doc/library/pickle.rst File Doc/library/pickle.rst (right): http://bugs.python.org/review/19189/diff/9465/Doc/library/pickle.rst#newcode394 Doc/library/pickle.rst:394: calling :meth:`~.object.__getstate__` is picklable (see section On 2013/10/13 20:29:35, ...
6 years, 7 months ago #2
Georg
http://bugs.python.org/review/19189/diff/9465/Doc/library/pickle.rst File Doc/library/pickle.rst (right): http://bugs.python.org/review/19189/diff/9465/Doc/library/pickle.rst#newcode394 Doc/library/pickle.rst:394: calling :meth:`~.object.__getstate__` is picklable (see section On 2013/10/13 23:07:18, ...
6 years, 7 months ago #3
storchaka_gmail.com
6 years, 7 months ago #4
http://bugs.python.org/review/19189/diff/9465/Doc/library/pickle.rst
File Doc/library/pickle.rst (right):

http://bugs.python.org/review/19189/diff/9465/Doc/library/pickle.rst#newcode394
Doc/library/pickle.rst:394: calling :meth:`~.object.__getstate__` is picklable 
(see section
On 2013/10/13 23:13:12, Georg wrote:
> On 2013/10/13 23:07:18, storchaka wrote:
> > On 2013/10/13 20:29:35, Georg wrote:
> > > ~object. should never be needed for methods.
> > > 
> > > These appear to be false positives.
> > 
> > Here is not "~object." but "~.object.". These methods are declared in the
"."
> > module (see line 438 below). Do you know how declare empty module?
> 
> 
> Yes, use ``.. currentmodule:: None``.

Thank you. This will made the patch much better.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+