Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37606)

#19132: Add compact mode to pprint

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by storchaka+cpython
Modified:
6 years ago
Reviewers:
rdmurray
CC:
AntoinePitrou, r.david.murray, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 9

Patch Set 2 #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/pprint.rst View 1 2 4 chunks +20 lines, -11 lines 0 comments Download
Lib/pprint.py View 1 2 6 chunks +39 lines, -14 lines 0 comments Download
Lib/test/test_pprint.py View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2
r.david.murray
http://bugs.python.org/review/19132/diff/9408/Doc/library/pprint.rst File Doc/library/pprint.rst (right): http://bugs.python.org/review/19132/diff/9408/Doc/library/pprint.rst#newcode39 Doc/library/pprint.rst:39: formatted representation. The keywords are *indent*, *depth*, *width*, and ...
6 years ago #1
storchaka_gmail.com
6 years ago #2
http://bugs.python.org/review/19132/diff/9408/Doc/library/pprint.rst
File Doc/library/pprint.rst (right):

http://bugs.python.org/review/19132/diff/9408/Doc/library/pprint.rst#newcode39
Doc/library/pprint.rst:39: formatted representation.  The keywords are *indent*,
*depth*, *width*, and *compact*.  The
On 2013/09/30 20:50:07, r.david.murray wrote:
> I personally dislike descriptions that count things, since the number counted
> tends to grow and as it gets longer sometimes gets out of sync.  I'd just
delete
> these two sentences entirely.

Done.

http://bugs.python.org/review/19132/diff/9408/Doc/library/pprint.rst#newcode50
Doc/library/pprint.rst:50: be combined in one line.
On 2013/09/30 20:50:07, r.david.murray wrote:
> "each item of a long sequence will be formatted on a separate line.  If
> *compact* is true, as many items as will fit within the *width* will be
> formatted on each output line.

Done.

http://bugs.python.org/review/19132/diff/9408/Doc/library/pprint.rst#newcode80
Doc/library/pprint.rst:80: Return the formatted representation of *object* as a
string.  *indent*, *width*,
On 2013/09/30 20:50:07, r.david.murray wrote:
> You might as well rewrap this to 79 cols in this patch since the line is
> changing anyway.

Done.

http://bugs.python.org/review/19132/diff/9408/Doc/library/pprint.rst#newcode85
Doc/library/pprint.rst:85: .. function:: pprint(object, stream=None, indent=1,
width=80, depth=None *, compact=False)
On 2013/09/30 20:50:07, r.david.murray wrote:
> You can wrap this to keep the source line under 80 chars.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+