Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

#18973: Use argparse in the calendar module

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by storchaka+cpython
Modified:
4 years, 2 months ago
Reviewers:
stephane, ghost.adh
CC:
rhettinger, bethard, r.david.murray, devnull_psf.upfronthosting.co.za, storchaka, matrixise, vajrasky
Visibility:
Public.

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/calendar.py View 3 chunks +41 lines, -32 lines 7 comments Download

Messages

Total messages: 4
matrixise
I have reviewed the patch, this is one is correct for 3.6. In fact, I ...
4 years, 3 months ago #1
ghost.adh_gmail.com
https://bugs.python.org/review/18973/diff/9225/Lib/calendar.py File Lib/calendar.py (right): https://bugs.python.org/review/18973/diff/9225/Lib/calendar.py#newcode614 Lib/calendar.py:614: dest="width", type=int, default=2, dest arguments are not required given ...
4 years, 3 months ago #2
matrixise
https://bugs.python.org/review/18973/diff/9225/Lib/calendar.py File Lib/calendar.py (right): https://bugs.python.org/review/18973/diff/9225/Lib/calendar.py#newcode614 Lib/calendar.py:614: dest="width", type=int, default=2, On 2015/10/28 22:08:44, SilentGhost wrote: > ...
4 years, 3 months ago #3
storchaka_gmail.com
4 years, 2 months ago #4
http://bugs.python.org/review/18973/diff/9225/Lib/calendar.py
File Lib/calendar.py (right):

http://bugs.python.org/review/18973/diff/9225/Lib/calendar.py#newcode614
Lib/calendar.py:614: dest="width", type=int, default=2,
On 2015/10/28 22:08:44, SilentGhost wrote:
> dest arguments are not required given they're just repeating the long option

Done.

http://bugs.python.org/review/18973/diff/9225/Lib/calendar.py#newcode655
Lib/calendar.py:655: action="store", nargs='?', type=int,
On 2015/10/28 22:08:44, SilentGhost wrote:
> store is a default action, the same is on line 660

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+