Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(34212)

#18891: Master patch for content manager addtion to email package.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by rdmurray
Modified:
5 years, 3 months ago
Reviewers:
pitrou, stephen, storchaka
CC:
barry, r.david.murray, StephenTurnbull, devnull_psf.upfronthosting.co.za, eric.snow, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 63

Patch Set 2 #

Patch Set 3 #

Total comments: 32

Patch Set 4 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/email.contentmanager.rst View 1 2 3 1 chunk +427 lines, -0 lines 2 comments Download
Doc/library/email.message.rst View 1 2 3 3 chunks +13 lines, -5 lines 0 comments Download
Doc/library/email.policy.rst View 1 2 3 6 chunks +24 lines, -10 lines 0 comments Download
Doc/library/email.rst View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
Lib/email/contentmanager.py View 1 2 3 1 chunk +249 lines, -0 lines 0 comments Download
Lib/email/message.py View 1 2 3 4 chunks +212 lines, -5 lines 0 comments Download
Lib/email/policy.py View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
Lib/email/utils.py View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download
Lib/test/test_email/__init__.py View 1 2 3 5 chunks +25 lines, -1 line 0 comments Download
Lib/test/test_email/test_contentmanager.py View 1 2 3 1 chunk +796 lines, -0 lines 0 comments Download
Lib/test/test_email/test_headerregistry.py View 1 2 3 2 chunks +13 lines, -1 line 0 comments Download
Lib/test/test_email/test_message.py View 1 2 3 2 chunks +741 lines, -1 line 0 comments Download
Lib/test/test_email/test_policy.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10
AntoinePitrou
http://bugs.python.org/review/18891/diff/9115/Doc/library/email.contentmanager.rst File Doc/library/email.contentmanager.rst (right): http://bugs.python.org/review/18891/diff/9115/Doc/library/email.contentmanager.rst#newcode1 Doc/library/email.contentmanager.rst:1: :mod:`email.contentmanager: Managing MIME Content missing a closing backquote, I ...
5 years, 4 months ago #1
StephenTurnbull
Time to sleep. Will try to get to the rest of it tomorrow. http://bugs.python.org/review/18891/diff/9115/Doc/library/email.contentmanager.rst File ...
5 years, 4 months ago #2
StephenTurnbull
This really looks good to me. There's a fair amount of bikeshedding to be done ...
5 years, 4 months ago #3
r.david.murray
http://bugs.python.org/review/18891/diff/9115/Doc/library/email.contentmanager.rst File Doc/library/email.contentmanager.rst (right): http://bugs.python.org/review/18891/diff/9115/Doc/library/email.contentmanager.rst#newcode1 Doc/library/email.contentmanager.rst:1: :mod:`email.contentmanager: Managing MIME Content On 2013/08/31 14:17:30, AntoinePitrou wrote: ...
5 years, 4 months ago #4
r.david.murray
http://bugs.python.org/review/18891/diff/9115/Doc/library/email.contentmanager.rst File Doc/library/email.contentmanager.rst (right): http://bugs.python.org/review/18891/diff/9115/Doc/library/email.contentmanager.rst#newcode24 Doc/library/email.contentmanager.rst:24: a useful and flexible API, but it only knows ...
5 years, 4 months ago #5
storchaka_gmail.com
http://bugs.python.org/review/18891/diff/9511/Lib/email/contentmanager.py File Lib/email/contentmanager.py (right): http://bugs.python.org/review/18891/diff/9511/Lib/email/contentmanager.py#newcode46 Lib/email/contentmanager.py:46: full_path = '.'.join((modname, qname)) if modname else qname This ...
5 years, 3 months ago #6
r.david.murray
Thanks for the review! http://bugs.python.org/review/18891/diff/9511/Lib/email/contentmanager.py File Lib/email/contentmanager.py (right): http://bugs.python.org/review/18891/diff/9511/Lib/email/contentmanager.py#newcode46 Lib/email/contentmanager.py:46: full_path = '.'.join((modname, qname)) if ...
5 years, 3 months ago #7
r.david.murray
Thanks for the review!
5 years, 3 months ago #8
storchaka_gmail.com
http://bugs.python.org/review/18891/diff/9511/Lib/email/message.py File Lib/email/message.py (right): http://bugs.python.org/review/18891/diff/9511/Lib/email/message.py#newcode1052 Lib/email/message.py:1052: name, value = self._headers.pop(0) On 2013/10/12 23:39:42, r.david.murray wrote: ...
5 years, 3 months ago #9
r.david.murray
5 years, 3 months ago #10
http://bugs.python.org/review/18891/diff/9511/Lib/email/message.py
File Lib/email/message.py (right):

http://bugs.python.org/review/18891/diff/9511/Lib/email/message.py#newcode1052
Lib/email/message.py:1052: name, value = self._headers.pop(0)
On 2013/10/15 00:12:21, storchaka wrote:
> On 2013/10/12 23:39:42, r.david.murray wrote:
> > On 2013/10/12 14:02:22, storchaka wrote:
> > > Does not this have O(N) complexity? And O(N**2) total complexity? Why not
> use
> > > "for name, value in self._headers:... self._headers = keep_headers" which
> has
> > > linear complexity?
> > 
> > I no longer remember why I coded it that way.  There was a reason
originally,
> > but the code changed several times and it certainly doesn't look like there
is
> > any reason any more :)
> > 
> > Fixed.
> 
> Fixed?

Heh.  I forgot to make the actual fix, obviously.  I just changed it in my copy,
so the fix will be in the committed patch.

http://bugs.python.org/review/18891/diff/9521/Doc/library/email.contentmanage...
File Doc/library/email.contentmanager.rst (right):

http://bugs.python.org/review/18891/diff/9521/Doc/library/email.contentmanage...
Doc/library/email.contentmanager.rst:64: RFCs except for line endings (instead
of the RFC mandated ``\r\n``, it uses
On 2013/10/15 00:12:21, storchaka wrote:
> I don't remember, should backslash be escaped here?

Nope, the `` is 'literal code' markup, so it does the escaping automatically.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+