Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(128)

#18818: Empty PYTHONIOENCODING is not the same as nonexistent

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 3 months ago by storchaka+cpython
Modified:
5 years, 3 months ago
Reviewers:
ezio.melotti, sky.kok
CC:
Nick Coghlan, haypo, Arfrever, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/using/cmdline.rst View 1 2 3 1 chunk +6 lines, -3 lines 2 comments Download
Lib/test/test_sys.py View 1 2 3 1 chunk +32 lines, -0 lines 1 comment Download
Python/pythonrun.c View 1 2 3 3 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 2
ezio.melotti
http://bugs.python.org/review/18818/diff/9057/Doc/using/cmdline.rst File Doc/using/cmdline.rst (right): http://bugs.python.org/review/18818/diff/9057/Doc/using/cmdline.rst#newcode542 Doc/using/cmdline.rst:542: ``encodingname`` and ``:errorhandler`` parts are optional and has the ...
5 years, 3 months ago #1
vajrasky
5 years, 3 months ago #2
http://bugs.python.org/review/18818/diff/9057/Lib/test/test_sys.py
File Lib/test/test_sys.py (right):

http://bugs.python.org/review/18818/diff/9057/Lib/test/test_sys.py#newcode565
Lib/test/test_sys.py:565: if test.support.FS_NONASCII:
Perhaps it is better if we extract this case to a dedicated unit test method and
use unittest.skipUnless decorator. Sometimes I want to know what I am missing
(skipping) when running the test.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7