Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(115318)

#18794: select.devpoll objects have no close() method

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by vstinner
Modified:
6 years, 2 months ago
Reviewers:
cf.natali
CC:
jcea, haypo, Charles-François Natali, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/select.rst View 1 3 chunks +31 lines, -0 lines 0 comments Download
Lib/test/test_devpoll.py View 1 1 chunk +26 lines, -0 lines 2 comments Download
Lib/test/test_epoll.py View 1 1 chunk +26 lines, -0 lines 1 comment Download
Lib/test/test_kqueue.py View 1 1 chunk +20 lines, -0 lines 0 comments Download
Modules/selectmodule.c View 1 10 chunks +85 lines, -7 lines 0 comments Download

Messages

Total messages: 5
Charles-François Natali
http://bugs.python.org/review/18794/diff/9018/Lib/test/test_select.py File Lib/test/test_select.py (right): http://bugs.python.org/review/18794/diff/9018/Lib/test/test_select.py#newcode79 Lib/test/test_select.py:79: class CloseTest(unittest.TestCase): I think those tests should be moved ...
6 years, 2 months ago #1
gvanrossum
I'm withdrawing from this code review.
6 years, 2 months ago #2
Charles-François Natali
http://bugs.python.org/review/18794/diff/9024/Lib/test/test_devpoll.py File Lib/test/test_devpoll.py (right): http://bugs.python.org/review/18794/diff/9024/Lib/test/test_devpoll.py#newcode97 Lib/test/test_devpoll.py:97: fd = obj.fileno() You're redefining 'fd' defined above: this ...
6 years, 2 months ago #3
Charles-François Natali
6 years, 2 months ago #4
gvanrossum
6 years, 2 months ago #5

          
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+