Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(160494)

#18761: Fix internal doc references for the email package (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by storchaka+cpython
Modified:
6 years, 3 months ago
Reviewers:
rdmurray, ezio.melotti, merwok
CC:
barry, Georg, ezio.melotti, eric.araujo, r.david.murray, docs_python.org, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 22

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/email.errors.rst View 1 4 chunks +16 lines, -13 lines 0 comments Download
Doc/library/email.headerregistry.rst View 1 4 chunks +8 lines, -7 lines 0 comments Download
Doc/library/email.iterators.rst View 1 2 chunks +7 lines, -4 lines 0 comments Download
Doc/library/email.message.rst View 1 4 chunks +8 lines, -6 lines 0 comments Download
Doc/library/email.mime.rst View 1 6 chunks +19 lines, -10 lines 0 comments Download
Doc/library/email.parser.rst View 1 9 chunks +32 lines, -24 lines 0 comments Download
Doc/library/email.policy.rst View 1 2 chunks +5 lines, -4 lines 0 comments Download
Doc/library/email.rst View 1 7 chunks +104 lines, -79 lines 0 comments Download
Doc/library/email.util.rst View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7
r.david.murray
http://bugs.python.org/review/18761/diff/8959/Doc/library/email.errors.rst File Doc/library/email.errors.rst (left): http://bugs.python.org/review/18761/diff/8959/Doc/library/email.errors.rst#oldcode50 Doc/library/email.errors.rst:50: :meth:`add_payload`, but the payload is already a scalar and ...
6 years, 3 months ago #1
ezio.melotti
http://bugs.python.org/review/18761/diff/8959/Doc/library/email.rst File Doc/library/email.rst (right): http://bugs.python.org/review/18761/diff/8959/Doc/library/email.rst#newcode300 Doc/library/email.rst:300: * The method :meth:`setboundary` was renamed to :meth:`~email.message.Message.set_boundary`. Is ...
6 years, 3 months ago #2
r.david.murray
6 years, 3 months ago #3
eric.araujo
http://bugs.python.org/review/18761/diff/8959/Doc/library/email.headerregistry.rst File Doc/library/email.headerregistry.rst (left): http://bugs.python.org/review/18761/diff/8959/Doc/library/email.headerregistry.rst#oldcode59 Doc/library/email.headerregistry.rst:59: is exactly the value passed in the :attr:`~EmailPolicy.header_factory` Depends ...
6 years, 3 months ago #4
r.david.murray
http://bugs.python.org/review/18761/diff/8959/Doc/library/email.headerregistry.rst File Doc/library/email.headerregistry.rst (right): http://bugs.python.org/review/18761/diff/8959/Doc/library/email.headerregistry.rst#newcode233 Doc/library/email.headerregistry.rst:233: the RFC under the default :mod:`~email.policy`), accessing this attribute ...
6 years, 3 months ago #5
storchaka_gmail.com
http://bugs.python.org/review/18761/diff/8959/Doc/library/email.errors.rst File Doc/library/email.errors.rst (left): http://bugs.python.org/review/18761/diff/8959/Doc/library/email.errors.rst#oldcode50 Doc/library/email.errors.rst:50: :meth:`add_payload`, but the payload is already a scalar and ...
6 years, 3 months ago #6
storchaka_gmail.com
6 years, 3 months ago #7
http://bugs.python.org/review/18761/diff/8959/Doc/library/email.rst
File Doc/library/email.rst (right):

http://bugs.python.org/review/18761/diff/8959/Doc/library/email.rst#newcode300
Doc/library/email.rst:300: * The method :meth:`setboundary` was renamed to
:meth:`~email.message.Message.set_boundary`.
On 2013/08/16 23:38:47, ezio.melotti wrote:
> Is there any way to either set a shortcut somewhere for email.message.Message
or
> set is as current class/module?

Yes, we can change current module and class. But then we should change them back
when we want refers to entities in other modules/classes. And we should always
remember which module and class are current (it can be declared several pages
above). I think explicitness is better here.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+