Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(118539)

#18756: os.urandom() fails under high load

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by lists
Modified:
6 years, 2 months ago
Reviewers:
pitrou, cf.natali, benjamin
CC:
jcea, AntoinePitrou, haypo, christian.heimes, tarek_ziade.org, alex, Charles-François Natali, Adam.Bielański, devnull_psf.upfronthosting.co.za, hynek, dstufft
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 5

Patch Set 3 #

Patch Set 4 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/pythonrun.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_cmd_line.py View 1 2 3 2 chunks +8 lines, -3 lines 1 comment Download
Lib/test/test_os.py View 1 2 3 1 chunk +16 lines, -10 lines 0 comments Download
Python/pythonrun.c View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
Python/random.c View 1 2 3 6 chunks +84 lines, -14 lines 3 comments Download

Messages

Total messages: 7
christian.heimes
http://bugs.python.org/review/18756/diff/8956/Python/random.c File Python/random.c (right): http://bugs.python.org/review/18756/diff/8956/Python/random.c#newcode141 Python/random.c:141: fd = open("/dev/urandom", O_RDONLY); You should add O_CLOEXEC here ...
6 years, 3 months ago #1
AntoinePitrou
http://bugs.python.org/review/18756/diff/8956/Python/random.c File Python/random.c (right): http://bugs.python.org/review/18756/diff/8956/Python/random.c#newcode160 Python/random.c:160: urandom_fd = fd; On 2013/08/16 21:48:43, christian.heimes wrote: > ...
6 years, 3 months ago #2
Charles-François Natali
http://bugs.python.org/review/18756/diff/8956/Python/random.c#newcode177 > Python/random.c:177: /* stop on error or if read(size) returned 0 */ > I ...
6 years, 3 months ago #3
AntoinePitrou
On 2013/08/16 23:13:21, Charles-François Natali wrote: > > IMO that's a bad idea. > This ...
6 years, 3 months ago #4
Charles-François Natali
http://bugs.python.org/review/18756/diff/9059/Python/random.c File Python/random.c (right): http://bugs.python.org/review/18756/diff/9059/Python/random.c#newcode193 Python/random.c:193: something else. */ Holy crap :-) But AFAICT this ...
6 years, 2 months ago #5
AntoinePitrou
http://bugs.python.org/review/18756/diff/9059/Python/random.c File Python/random.c (right): http://bugs.python.org/review/18756/diff/9059/Python/random.c#newcode193 Python/random.c:193: something else. */ On 2013/08/23 23:07:39, Charles-François Natali wrote: ...
6 years, 2 months ago #6
Benjamin Peterson
6 years, 2 months ago #7
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+