Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(178590)

#18725: Multiline shortening

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by storchaka+cpython
Modified:
5 years, 9 months ago
Reviewers:
ezio.melotti
CC:
barry, Georg, AntoinePitrou, ezio.melotti, stevenjd, r.david.murray, devnull_psf.upfronthosting.co.za, storchaka, vajrasky
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/textwrap.rst View 1 2 chunks +16 lines, -12 lines 0 comments Download
Lib/test/test_textwrap.py View 1 5 chunks +98 lines, -7 lines 0 comments Download
Lib/textwrap.py View 1 9 chunks +49 lines, -39 lines 0 comments Download

Messages

Total messages: 4
ezio.melotti
http://bugs.python.org/review/18725/diff/9276/Lib/test/test_textwrap.py File Lib/test/test_textwrap.py (right): http://bugs.python.org/review/18725/diff/9276/Lib/test/test_textwrap.py#newcode501 Lib/test/test_textwrap.py:501: self.check_wrap(self.text, 80, [self.text], placeholder='.' * 1000) I would add ...
5 years, 9 months ago #1
storchaka_gmail.com
http://bugs.python.org/review/18725/diff/9276/Lib/test/test_textwrap.py File Lib/test/test_textwrap.py (right): http://bugs.python.org/review/18725/diff/9276/Lib/test/test_textwrap.py#newcode501 Lib/test/test_textwrap.py:501: self.check_wrap(self.text, 80, [self.text], placeholder='.' * 1000) On 2013/10/03 15:27:57, ...
5 years, 9 months ago #2
ezio.melotti
http://bugs.python.org/review/18725/diff/9276/Lib/test/test_textwrap.py File Lib/test/test_textwrap.py (right): http://bugs.python.org/review/18725/diff/9276/Lib/test/test_textwrap.py#newcode501 Lib/test/test_textwrap.py:501: self.check_wrap(self.text, 80, [self.text], placeholder='.' * 1000) On 2013/10/03 20:29:57, ...
5 years, 9 months ago #3
storchaka_gmail.com
5 years, 9 months ago #4
http://bugs.python.org/review/18725/diff/9276/Lib/test/test_textwrap.py
File Lib/test/test_textwrap.py (right):

http://bugs.python.org/review/18725/diff/9276/Lib/test/test_textwrap.py#newco...
Lib/test/test_textwrap.py:501: self.check_wrap(self.text, 80, [self.text],
placeholder='.' * 1000)
On 2013/10/05 18:43:25, ezio.melotti wrote:
> On 2013/10/03 20:29:57, storchaka wrote:
> > On 2013/10/03 15:27:57, ezio.melotti wrote:
> > > I would add some test with new lines and empty lines as well (assuming
they
> > are
> > > supported).
> > 
> > What you mean? Could you provide some example?
> 
> text = "Hello there, how are you this fine day?\nI'm glad to hear it!"
> text = "Hello there, how are you this fine day?\n\n\nI'm glad to hear it!\n\n"
> 
> I don't know if the function is supposed to work with strings with new lines
> too, but regardless of this I think we should check that the function behaves
> reasonably for these cases.

There is nothing special with max_lines and placeholder. See issue1859.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+