Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95208)

#18604: Consolidate gui available checks in test.support

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by tjreedy
Modified:
5 years, 3 months ago
Reviewers:
zachary.ware
CC:
terry.reedy, ned.deily, ezio.melotti, r.david.murray, devnull_psf.upfronthosting.co.za, Zach Ware
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/support/__init__.py View 1 4 chunks +55 lines, -12 lines 0 comments Download
Lib/test/test_idle.py View 1 1 chunk +1 line, -13 lines 0 comments Download
Lib/test/test_tk.py View 1 1 chunk +1 line, -2 lines 0 comments Download
Lib/test/test_ttk_guionly.py View 1 1 chunk +1 line, -2 lines 0 comments Download
Lib/tkinter/test/support.py View 1 1 chunk +2 lines, -44 lines 0 comments Download

Messages

Total messages: 1
Zach Ware
5 years, 7 months ago #1
http://bugs.python.org/review/18604/diff/10436/Lib/test/support/__init__.py
File Lib/test/support/__init__.py (right):

http://bugs.python.org/review/18604/diff/10436/Lib/test/support/__init__.py#n...
Lib/test/support/__init__.py:438: try:
It looks like I attached the wrong patch.  This block is supposed to be guarded
by an "if not reason:" check to avoid crashes.

http://bugs.python.org/review/18604/diff/10436/Lib/tkinter/test/runtktests.py
File Lib/tkinter/test/runtktests.py (right):

http://bugs.python.org/review/18604/diff/10436/Lib/tkinter/test/runtktests.py...
Lib/tkinter/test/runtktests.py:52: if 'gui' in str(e) and gui:
This change makes test_ttk_textonly actually run when the gui resource is not
allowed/available.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+