Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(277674)

#18582: PBKDF2 support

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by lists
Modified:
5 years, 10 months ago
Reviewers:
pitrou
CC:
AntoinePitrou, christian.heimes, devnull_psf.upfronthosting.co.za, dstufft
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 5

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/hashlib.rst View 1 2 3 4 3 chunks +41 lines, -0 lines 0 comments Download
Lib/hashlib.py View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
Lib/test/test_hashlib.py View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
Modules/_hashopenssl.c View 1 2 3 4 4 chunks +132 lines, -0 lines 0 comments Download

Messages

Total messages: 1
AntoinePitrou
5 years, 10 months ago #1
http://bugs.python.org/review/18582/diff/9522/Doc/library/hashlib.rst
File Doc/library/hashlib.rst (right):

http://bugs.python.org/review/18582/diff/9522/Doc/library/hashlib.rst#newcode186
Doc/library/hashlib.rst:186: against brute-force attacks.
Explain that it's because the hash function is too fast?

http://bugs.python.org/review/18582/diff/9522/Doc/library/hashlib.rst#newcode191
Doc/library/hashlib.rst:191: The function provides an interface to OpenSSL's
implementation of PKCS#5
The fact that it's OpenSSL's implementation probably doesn't matter. We're
documenting the API.

http://bugs.python.org/review/18582/diff/9522/Lib/hashlib.py
File Lib/hashlib.py (right):

http://bugs.python.org/review/18582/diff/9522/Lib/hashlib.py#newcode151
Lib/hashlib.py:151: from _hashlib import pbkdf2_hmac
Add it to __all__ as well?

http://bugs.python.org/review/18582/diff/9522/Lib/test/test_hashlib.py
File Lib/test/test_hashlib.py (right):

http://bugs.python.org/review/18582/diff/9522/Lib/test/test_hashlib.py#newcod...
Lib/test/test_hashlib.py:552: #(b'password', b'salt', 16777216, None),
Why is this one commented out? Too slow?

http://bugs.python.org/review/18582/diff/9522/Modules/_hashopenssl.c
File Modules/_hashopenssl.c (right):

http://bugs.python.org/review/18582/diff/9522/Modules/_hashopenssl.c#newcode719
Modules/_hashopenssl.c:719: #if PY_PBKDF2_HMAC
#ifdef, no?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+