Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(90522)

#18418: Thread.isAlive() sometimes True after fork

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by jesse
Modified:
6 years, 3 months ago
Reviewers:
cf.natali
CC:
gregory.p.smith, AntoinePitrou, Charles-François Natali, devnull_psf.upfronthosting.co.za, sbt, koobs, A. Jesse Jiryu Davis
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 2

Patch Set 4 #

Total comments: 4

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_threading.py View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
Lib/threading.py View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Charles-François Natali
Here's a review. But I still think that it's not the best approach. It would ...
6 years, 3 months ago #1
Charles-François Natali
http://bugs.python.org/review/18418/diff/8739/Lib/threading.py File Lib/threading.py (right): http://bugs.python.org/review/18418/diff/8739/Lib/threading.py#newcode941 Lib/threading.py:941: for thread in itertools.chain(_active.values(), _limbo.values()): You could just use ...
6 years, 3 months ago #2
Charles-François Natali
http://bugs.python.org/review/18418/diff/8739/Lib/test/test_threading.py File Lib/test/test_threading.py (right): http://bugs.python.org/review/18418/diff/8739/Lib/test/test_threading.py#newcode465 Lib/test/test_threading.py:465: (_, exit_status) = os.waitpid(pid, 0) You should also join() ...
6 years, 3 months ago #3
A. Jesse Jiryu Davis
6 years, 3 months ago #4
http://bugs.python.org/review/18418/diff/8739/Lib/test/test_threading.py
File Lib/test/test_threading.py (right):

http://bugs.python.org/review/18418/diff/8739/Lib/test/test_threading.py#newc...
Lib/test/test_threading.py:465: (_, exit_status) = os.waitpid(pid, 0)
On 2013/08/02 09:06:55, Charles-François Natali wrote:
> You should also join() the thread.

Done.

http://bugs.python.org/review/18418/diff/8739/Lib/threading.py
File Lib/threading.py (right):

http://bugs.python.org/review/18418/diff/8739/Lib/threading.py#newcode941
Lib/threading.py:941: for thread in itertools.chain(_active.values(),
_limbo.values()):
On 2013/07/27 11:33:35, Charles-François Natali wrote:
> You could just use _enumerate().

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+