Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

#18416: Move to absolute file paths for module.__file__

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by brett
Modified:
6 years, 6 months ago
Reviewers:
madison.may
CC:
brett.cannon, Ronald Oussoren, Nick Coghlan, Arfrever, devnull_psf.upfronthosting.co.za, eric.snow, madison.may
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/importlib/_bootstrap.py View 2 chunks +2 lines, -2 lines 0 comments Download
Lib/test/test_importlib/import_/test_path.py View 1 chunk +2 lines, -2 lines 0 comments Download
Lib/test/test_import.py View 1 chunk +17 lines, -0 lines 1 comment Download
Python/importlib.h View 99 chunks +1446 lines, -1445 lines 0 comments Download

Messages

Total messages: 2
brett.cannon
http://bugs.python.org/review/18416/diff/8885/Lib/test/test_import.py File Lib/test/test_import.py (right): http://bugs.python.org/review/18416/diff/8885/Lib/test/test_import.py#newcode253 Lib/test/test_import.py:253: @skip_if_dont_write_bytecode Why are you skipping bytecode? I don't see ...
6 years, 6 months ago #1
madison.may
6 years, 6 months ago #2
On 2013/08/12 18:13:38, brett.cannon wrote:
> http://bugs.python.org/review/18416/diff/8885/Lib/test/test_import.py
> File Lib/test/test_import.py (right):
> 
>
http://bugs.python.org/review/18416/diff/8885/Lib/test/test_import.py#newcode253
> Lib/test/test_import.py:253: @skip_if_dont_write_bytecode
> Why are you skipping bytecode? I don't see any reason that this test is
> bytecode-specific.

Whoops, sorry about that.  I was modeling the test after a similar one and
neglected to remove that decorator.  Thanks, Brett.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+