Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(34)

#18379: SSLSocket.getpeercert(): OCSP and CRL DP URIs

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by lists
Modified:
4 years, 6 months ago
Reviewers:
pitrou
CC:
AntoinePitrou, christian.heimes, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/ssl.rst View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
Lib/test/test_ssl.py View 1 2 3 chunks +7 lines, -1 line 0 comments Download
Modules/_ssl.c View 1 2 3 chunks +151 lines, -1 line 4 comments Download

Messages

Total messages: 2
AntoinePitrou
http://bugs.python.org/review/18379/diff/8687/Modules/_ssl.c File Modules/_ssl.c (right): http://bugs.python.org/review/18379/diff/8687/Modules/_ssl.c#newcode936 Modules/_ssl.c:936: /* convert to tuple or None */ A list ...
4 years, 6 months ago #1
christian.heimes
4 years, 6 months ago #2
http://bugs.python.org/review/18379/diff/8687/Modules/_ssl.c
File Modules/_ssl.c (right):

http://bugs.python.org/review/18379/diff/8687/Modules/_ssl.c#newcode936
Modules/_ssl.c:936: /* convert to tuple or None */
On 2013/11/17 16:09:23, AntoinePitrou wrote:
> A list would sound fine, intuitively. Is it because the cert representation
uses
> tuples in other places?

Yes, all remaining fields are tuples, e.g. subjectAltName. I'd like to keep it
consistent.

http://bugs.python.org/review/18379/diff/8687/Modules/_ssl.c#newcode949
Modules/_ssl.c:949: Py_DECREF(lst);
On 2013/11/17 16:09:23, AntoinePitrou wrote:
> Py_XDECREF, as lst can be NULL.

Good catch!
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7