Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33850)

#18193: Move imp.reload() to importlib

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by brett
Modified:
5 years, 7 months ago
Reviewers:
berker.peksag
CC:
brett.cannon, Arfrever, devnull_psf.upfronthosting.co.za, berkerpeksag
Visibility:
Public.

Patch Set 1 #

Total comments: 9

Patch Set 2 #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/importlib.rst View 1 2 1 chunk +63 lines, -0 lines 0 comments Download
Doc/library/imp.rst View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
Lib/importlib/__init__.py View 1 2 2 chunks +33 lines, -1 line 0 comments Download
Lib/imp.py View 1 2 2 chunks +5 lines, -23 lines 0 comments Download
Lib/test/test_importlib/test_api.py View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3
brett.cannon
Thanks for the patch. Minor touch-ups and then it should be good to go. http://bugs.python.org/review/18193/diff/8383/Lib/imp.py ...
5 years, 7 months ago #1
berkerpeksag
http://bugs.python.org/review/18193/diff/8383/Lib/imp.py File Lib/imp.py (left): http://bugs.python.org/review/18193/diff/8383/Lib/imp.py#oldcode257 Lib/imp.py:257: if not module or type(module) != type(sys): On 2013/06/13 ...
5 years, 7 months ago #2
brett.cannon
5 years, 7 months ago #3
http://bugs.python.org/review/18193/diff/8383/Lib/test/test_importlib/test_ap...
File Lib/test/test_importlib/test_api.py (right):

http://bugs.python.org/review/18193/diff/8383/Lib/test/test_importlib/test_ap...
Lib/test/test_importlib/test_api.py:160: # XXX (ncoghlan): It would be nice to
use test.support.CleanImport
On 2013/06/14 18:29:35, berkerpeksag wrote:
> On 2013/06/13 17:24:56, brett.cannon wrote:
> > Could you see if using a simpler module like tokenize or something works
just
> as
> > well as a test case to avoid this issue? I don't see any specific reason to
> use
> > os over any other module.
> 
> Done.
> 
> Should I use ``importlib.import_module('tokenize')`` instead of ``import
> tokenize`` as described in the  documentation of support.CleanImport?

Sure

> 
> >  def test_source(self):
> 
> Also, what does "source" mean here? :)

Python source code.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+