Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

#1818: Add named tuple reader to CSV module

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by raymond.hettinger
Modified:
2 years, 6 months ago
Reviewers:
skip
CC:
Skip, barry, rhettinger, AntoinePitrou, eric.araujo, ced, jervisau_gmail.com, rrenaud_google.com, asvetlov, dlenski_gmail.com, copper-head
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/csv.rst View 4 chunks +54 lines, -9 lines 0 comments Download
Lib/csv.py View 2 chunks +133 lines, -0 lines 2 comments Download
Lib/test/test_csv.py View 2 chunks +202 lines, -0 lines 0 comments Download

Messages

Total messages: 1
skip_pobox.com
2 years, 6 months ago #1
http://bugs.python.org/review/1818/diff/14678/Lib/csv.py
File Lib/csv.py (right):

http://bugs.python.org/review/1818/diff/14678/Lib/csv.py#newcode178
Lib/csv.py:178: # Unlike the basic reader we prefer not to return blank lines.
Can you motivate this choice? It seems like the user should be able to choose
whether to keep or toss blank lines. The csv module tries not to impose
semantics on the file's contents (no automatic type coercion, for instance). Who
are we to say the author of the file didn't mean something important with the
insertion of a blank line?

http://bugs.python.org/review/1818/diff/14678/Lib/csv.py#newcode248
Lib/csv.py:248: row[fields_len:] = [row[fields_len:]]
Should this restval be a tuple?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7