Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(127070)

#18149: filecmp.cmp() incorrect results when previously compared file is modified within modification time resolution

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by Matej.Froebe
Modified:
6 years, 5 months ago
Reviewers:
nad
CC:
rhettinger, nadeem.vawda, ned.deily, devnull_psf.upfronthosting.co.za, Matej.Froebe_MuellerBBM.de, melevittfl
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/filecmp.rst View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
Lib/filecmp.py View 1 2 5 chunks +8 lines, -3 lines 0 comments Download
Lib/test/test_filecmp.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 1
nad_acm.org
6 years, 5 months ago #1
Thanks for the patch, Mark.  Here are some review comments.   Also, the docs for
the filecmp module need to be updated: Doc/library/filecmp.rst.  And a test
would be nice:  Lib/test/test_filecmp.py

http://bugs.python.org/review/18149/diff/8372/Lib/filecmp.py
File Lib/filecmp.py (right):

http://bugs.python.org/review/18149/diff/8372/Lib/filecmp.py#newcode17
Lib/filecmp.py:17: __all__ = ['cmp', 'dircmp', 'cmpfiles', 'DEFAULT_IGNORES']
clear_cache should be added to __all__

http://bugs.python.org/review/18149/diff/8372/Lib/filecmp.py#newcode26
Lib/filecmp.py:26: """Clear the filecmp cache
I'd use a one-line docstring here
(http://www.python.org/dev/peps/pep-0257/#id18).  And don't forget the period.

http://bugs.python.org/review/18149/diff/8372/Lib/filecmp.py#newcode66
Lib/filecmp.py:66: _cache.clear()
In the spirit of DRY, I'd change this to call clear_cache.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+