Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(118372)

#18138: ssl.SSLContext.add_cert()

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by lists
Modified:
5 years, 11 months ago
Reviewers:
ezio.melotti, pitrou
CC:
jcea, AntoinePitrou, christian.heimes, ezio.melotti, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 #

Total comments: 7

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Total comments: 6

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/ssl.rst View 1 2 3 4 5 3 chunks +10 lines, -1 line 0 comments Download
Lib/test/test_ssl.py View 1 2 3 4 5 5 chunks +86 lines, -2 lines 0 comments Download
Modules/_ssl.c View 1 2 3 4 5 1 chunk +174 lines, -34 lines 0 comments Download

Messages

Total messages: 4
ezio.melotti
http://bugs.python.org/review/18138/diff/8307/Modules/_ssl.c File Modules/_ssl.c (right): http://bugs.python.org/review/18138/diff/8307/Modules/_ssl.c#newcode2349 Modules/_ssl.c:2349: Add an extra CA certificate. certdata must either be ...
6 years, 5 months ago #1
AntoinePitrou
http://bugs.python.org/review/18138/diff/8345/Lib/test/test_ssl.py File Lib/test/test_ssl.py (right): http://bugs.python.org/review/18138/diff/8345/Lib/test/test_ssl.py#newcode685 Lib/test/test_ssl.py:685: #self.assertEqual(ctx.get_cert_count(), 0) I suppose you want to replace this ...
6 years, 4 months ago #2
AntoinePitrou
http://bugs.python.org/review/18138/diff/10006/Lib/test/test_ssl.py File Lib/test/test_ssl.py (right): http://bugs.python.org/review/18138/diff/10006/Lib/test/test_ssl.py#newcode745 Lib/test/test_ssl.py:745: # test cadata Ok, perhaps make it a separate ...
5 years, 11 months ago #3
AntoinePitrou
5 years, 11 months ago #4
Looks good to me. Thanks!!
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+